Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6#2468
Merged
terrancedejesus merged 3 commits intomainfrom Jan 13, 2023
Merged
Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6#2468terrancedejesus merged 3 commits intomainfrom
terrancedejesus merged 3 commits intomainfrom
Conversation
github-actions
bot
requested review from
Mikaayenson,
brokensound77 and
terrancedejesus
as code owners
Comment on lines
+337
to
+350
| "min_stack_version": "8.4", | ||
| "previous": { | ||
| "8.3": { | ||
| "max_allowable_version": 103, | ||
| "rule_name": "Google Drive Ownership Transferred via Google Workspace", | ||
| "sha256": "1c82ea9b65fada4ec684045bd8b3e5eaa0730b35b41ddef3dd151ff26a9d6be9", | ||
| "type": "query", | ||
| "version": 4 | ||
| } | ||
| }, | ||
| "rule_name": "Google Drive Ownership Transferred via Google Workspace", | ||
| "sha256": "98600fe4b1c0c882bb99021122279f31ce5cdd2266abf34b56bab33f0cb7f190", | ||
| "type": "query", | ||
| "version": 3 | ||
| "version": 104 |
Contributor
There was a problem hiding this comment.
Forked at 8.3, where max allowable is =- the current as a buffer. SHA256 hashes differ where the 8.3 related integrations version value is 1.0.2 and 8.4+ is 2.0.0. Expected rule version changes should be expected for 8.4+ if the rule contents change, whereas the 8.3 fork is expected to not change unless manually.
These changes appear to be expected after the min-stack bump in #2467
terrancedejesus
requested review from
DefSecSentinel,
eric-forte-elastic,
imays11 and
w0rk3r
and removed request for
w0rk3r
terrancedejesus
approved these changes
Jan 13, 2023
Contributor
terrancedejesus
left a comment
terrancedejesus
left a comment
There was a problem hiding this comment.
LGTM. Changes appear to rule versions seem fine and no double bumps were identified. Google Workspace rules had a min-stack bump to 8.4 so forked 8.3 versions are expected. Max buffer amounts and current versions appear to be correct.
eric-forte-elastic
approved these changes
Jan 13, 2023
Contributor
There was a problem hiding this comment.
LGTM. 👍 Proper version update based on prior discussions. See reference
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6 * added newline in version lock file to trigger checks * removed trailing newline from version lock file Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: terrancedejesus <terrance.dejesus@elastic.co> (cherry picked from commit d81bc25)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6 * added newline in version lock file to trigger checks * removed trailing newline from version lock file Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: terrancedejesus <terrance.dejesus@elastic.co> (cherry picked from commit d81bc25)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6 * added newline in version lock file to trigger checks * removed trailing newline from version lock file Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: terrancedejesus <terrance.dejesus@elastic.co> (cherry picked from commit d81bc25)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6 * added newline in version lock file to trigger checks * removed trailing newline from version lock file Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: terrancedejesus <terrance.dejesus@elastic.co> (cherry picked from commit d81bc25)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6 * added newline in version lock file to trigger checks * removed trailing newline from version lock file Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: terrancedejesus <terrance.dejesus@elastic.co> (cherry picked from commit d81bc25)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6 * added newline in version lock file to trigger checks * removed trailing newline from version lock file Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: terrancedejesus <terrance.dejesus@elastic.co> (cherry picked from commit d81bc25)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6 * added newline in version lock file to trigger checks * removed trailing newline from version lock file Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: terrancedejesus <terrance.dejesus@elastic.co> (cherry picked from commit d81bc25)
protectionsmachine
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6 * added newline in version lock file to trigger checks * removed trailing newline from version lock file Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: terrancedejesus <terrance.dejesus@elastic.co> (cherry picked from commit d81bc25)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5,8.6.
lock-versions: pr.