Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Adding Adjustment to Route C of manage_versions.py #2307

Merged
merged 2 commits into from
Sep 19, 2022
Merged

[Bug] Adding Adjustment to Route C of manage_versions.py #2307

merged 2 commits into from
Sep 19, 2022

Conversation

terrancedejesus
Copy link
Contributor

@terrancedejesus terrancedejesus commented Sep 19, 2022 •
edited
Loading

Issues

Summary

Adjusted route C to update the dictionary for the lock_from_file variable as max_allowable_version was overwritten and therefore did not exist in the output.

Testing:

  1. Check out 8.2
  2. Update command_and_control_telnet_port_activity.toml in rule contents
  3. Run python -m detection_rules dev build-release --update-version-lock
  4. Check diff for version.lock.json file and notice max_allowable_version is missing

Bug Screenshot:
Screen Shot 2022-09-19 at 2 43 17 PM

Solution Screenshot:
Screen Shot 2022-09-19 at 2 19 27 PM

@terrancedejesus terrancedejesus added bug Something isn't working python Internal python for the repository labels Sep 19, 2022
@terrancedejesus terrancedejesus self-assigned this Sep 19, 2022
Mikaayenson
Mikaayenson approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@Mikaayenson Mikaayenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brokensound77
brokensound77 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@brokensound77 brokensound77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - after merging can you run a test lock

@terrancedejesus terrancedejesus merged commit 3c97d34 into main Sep 19, 2022
@terrancedejesus terrancedejesus deleted the version_lock_route_c_update branch September 19, 2022 18:50
protectionsmachine pushed a commit that referenced this pull request Sep 19, 2022
@terrancedejesus @github-actions
adding adjustment to route c of manage_versions (#2307)
bafab88 
(cherry picked from commit 3c97d34)
protectionsmachine pushed a commit that referenced this pull request Sep 19, 2022
@terrancedejesus @github-actions
adding adjustment to route c of manage_versions (#2307)
4e7e7be 
(cherry picked from commit 3c97d34)
protectionsmachine pushed a commit that referenced this pull request Sep 19, 2022
@terrancedejesus @github-actions
adding adjustment to route c of manage_versions (#2307)
2f54e75 
(cherry picked from commit 3c97d34)
protectionsmachine pushed a commit that referenced this pull request Sep 19, 2022
@terrancedejesus @github-actions
adding adjustment to route c of manage_versions (#2307)
327dc10 
(cherry picked from commit 3c97d34)
protectionsmachine pushed a commit that referenced this pull request Sep 19, 2022
@terrancedejesus @github-actions
adding adjustment to route c of manage_versions (#2307)
5cc7904 
(cherry picked from commit 3c97d34)
protectionsmachine pushed a commit that referenced this pull request Sep 19, 2022
@terrancedejesus @github-actions
adding adjustment to route c of manage_versions (#2307)
5da6185 
(cherry picked from commit 3c97d34)
@terrancedejesus terrancedejesus mentioned this pull request Jun 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brokensound77 brokensound77 brokensound77 approved these changes

@Mikaayenson Mikaayenson Mikaayenson approved these changes

Assignees

@terrancedejesus terrancedejesus

Labels
backport: auto bug Something isn't working python Internal python for the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrancedejesus @Mikaayenson @brokensound77