[Bug] Fix bug in version_lock.py #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokensound77
commented
Mar 24, 2022
| name = current_rule_lock['rule_name'] | ||
| existing_type = current_rule_lock['type'] | ||
| existing_type = existing_rule_lock['type'] |
There was a problem hiding this comment.
This was referencing the new lock info rather than the existing (lock file) lock info as expected
brokensound77
commented
Mar 24, 2022
| @@ -70,8 +70,8 @@ def manage_versions(self, rules: RuleCollection, | |||
| """Update the contents of the version.lock file and optionally save changes.""" | |||
| from .packaging import current_stack_version | |||
|
|
|||
| current_version_lock = deepcopy(self.version_lock) | |||
| version_lock_hash = dict_hash(current_version_lock) | |||
| lock_file_contents = deepcopy(self.version_lock) | |||
There was a problem hiding this comment.
this refactor is just for more clarity in the code
terrancedejesus
approved these changes
Mar 24, 2022
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit 17ef6c5)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit 17ef6c5)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit 17ef6c5)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit 17ef6c5)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit 17ef6c5)
protectionsmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit 17ef6c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
None
Summary
Noticed this didn't cause an expected failure when reviewing another PR, and found a small bug where the wrong lock was referenced