Change the JSON schema for the security_rule Kibana asset#1066
Merged
rw-access merged 2 commits intoelastic:mainfrom Mar 30, 2021
Merged
Change the JSON schema for the security_rule Kibana asset#1066rw-access merged 2 commits intoelastic:mainfrom
rw-access merged 2 commits intoelastic:mainfrom
Conversation
brokensound77
approved these changes
Mar 26, 2021
Contributor
brokensound77
left a comment
There was a problem hiding this comment.
Just the one requested change, then LGTM
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Realized in elastic/integrations#797 and some EPM observations that this isn't structured like other Kibana assets. EPM expects Kibana assets to look like this:
We don't have to make
attributesinternally consistent with other saved objects, but we might want to.We can still write our own installer in EPM anyway. See the reference on
AssetInstallersto see how index patterns are installed separately from other assets.Summary
References:
KibanaAssetTypedefines how it's installed