Skip to content

[8.18] Add some code coverage for SPO connector to be able to backport/merge stuff again (#3795) #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

[8.18] Add some code coverage for SPO connector to be able to backport/merge stuff again (#3795) #3800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions NOTICE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

MarkupSafe
3.0.3
UNKNOWN
BSD-3-Clause
Copyright 2010 Pallets

Redistribution and use in source and binary forms, with or without
Expand Down Expand Up @@ -91,8 +91,8 @@ SOFTWARE.


PyMySQL
1.1.1
MIT License
1.1.2
MIT
Copyright (c) 2010, 2013 PyMySQL contributors

Permission is hereby granted, free of charge, to any person obtaining a copy
Expand Down Expand Up @@ -1603,7 +1603,7 @@ Apache License

anyio
4.11.0
UNKNOWN
MIT
The MIT License (MIT)

Copyright (c) 2018 Alex Grönholm
Expand Down Expand Up @@ -1854,8 +1854,8 @@ Copyright (C) 2016-present the asyncpg authors and contributors.


attrs
25.3.0
UNKNOWN
25.4.0
MIT
The MIT License (MIT)

Copyright (c) 2015 Hynek Schlawack and the attrs contributors
Expand All @@ -1880,7 +1880,7 @@ SOFTWARE.


azure-core
1.35.1
1.36.0
MIT License
Copyright (c) Microsoft Corporation.

Expand Down Expand Up @@ -2164,7 +2164,7 @@ Apache Software License

beautifulsoup4
4.12.2
MIT License
MIT
Beautiful Soup is made available under the MIT license:

Copyright (c) Leonard Richardson
Expand Down Expand Up @@ -2564,7 +2564,7 @@ Apache Software License

bracex
2.6
MIT License
MIT
MIT License

Copyright (c) 2018 - 2025 Isaac Muse
Expand Down Expand Up @@ -2606,7 +2606,7 @@ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND


cachetools
6.2.0
6.2.1
MIT License
The MIT License (MIT)

Expand Down Expand Up @@ -2687,7 +2687,7 @@ documentation is licensed as follows:


charset-normalizer
3.4.3
3.4.4
MIT
MIT License

Expand Down Expand Up @@ -3341,7 +3341,7 @@ SOFTWARE

elasticsearch
8.17.1
Apache Software License
Apache-2.0

Apache License
Version 2.0, January 2004
Expand Down Expand Up @@ -3521,7 +3521,7 @@ Apache Software License


elasticsearch-connectors
8.18.7
8.18.9
Apache Software License
Elastic License 2.0

Expand Down Expand Up @@ -4384,7 +4384,7 @@ THE SOFTWARE.


grpcio
1.73.0
1.75.1
Apache Software License

Apache License
Expand Down Expand Up @@ -4999,7 +4999,7 @@ Exhibit B - "Incompatible With Secondary Licenses" Notice


grpcio-tools
1.71.0
1.71.2
Apache Software License
UNKNOWN

Expand Down Expand Up @@ -5032,7 +5032,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

httpcore
1.0.9
BSD License
BSD-3-Clause
Copyright © 2020, [Encode OSS Ltd](https://www.encode.io/).
All rights reserved.

Expand Down Expand Up @@ -5064,7 +5064,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

httpx
0.27.0
BSD License
BSD-3-Clause
Copyright © 2019, [Encode OSS Ltd](https://www.encode.io/).
All rights reserved.

Expand Down Expand Up @@ -5100,11 +5100,11 @@ OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.


idna
3.10
BSD License
3.11
BSD-3-Clause
BSD 3-Clause License

Copyright (c) 2013-2024, Kim Davies and contributors.
Copyright (c) 2013-2025, Kim Davies and contributors.
All rights reserved.

Redistribution and use in source and binary forms, with or without
Expand Down Expand Up @@ -5655,8 +5655,8 @@ MIT License


multidict
6.5.0
Apache Software License
6.7.0
Apache License 2.0
Copyright 2016 Andrew Svetlov and aio-libs contributors

Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -5977,7 +5977,7 @@ BSD
UNKNOWN

propcache
0.4.0
0.4.1
Apache Software License

Apache License
Expand Down Expand Up @@ -6725,7 +6725,7 @@ Apache Software License

pyspnego
0.12.0
UNKNOWN
MIT
MIT License

Copyright (c) 2020 Jordan Borean, Red Hat
Expand Down Expand Up @@ -7433,7 +7433,7 @@ made under the terms of *both* these licenses.

soupsieve
2.8
MIT License
MIT
MIT License

Copyright (c) 2018 - 2025 Isaac Muse <[email protected]>
Expand Down Expand Up @@ -7543,8 +7543,8 @@ Apache Software License
UNKNOWN

typing_extensions
4.14.1
UNKNOWN
4.15.0
PSF-2.0
A. HISTORY OF THE SOFTWARE
==========================

Expand Down Expand Up @@ -7885,7 +7885,7 @@ made under the terms of *both* these licenses.

urllib3
2.5.0
UNKNOWN
MIT
MIT License

Copyright (c) 2008-2020 Andrey Petrov and contributors.
Expand Down Expand Up @@ -8144,7 +8144,7 @@ SOFTWARE.


wrapt
1.17.2
1.17.3
BSD License
Copyright (c) 2013-2023, Graham Dumpleton
All rights reserved.
Expand Down Expand Up @@ -8173,7 +8173,7 @@ POSSIBILITY OF SUCH DAMAGE.


xmltodict
1.0.0
1.0.2
MIT License
Copyright (C) 2012 Martin Blech and individual contributors.

Expand All @@ -8185,7 +8185,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI


yarl
1.21.0
1.22.0
Apache Software License

Apache License
Expand Down
75 changes: 71 additions & 4 deletions tests/sources/test_sharepoint_online.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
_prefix_user,
_prefix_user_id,
)
from connectors.utils import iso_utc
from connectors.utils import ISO_ZULU_TIMESTAMP_FORMAT, iso_utc
from tests.commons import AsyncIterator
from tests.sources.support import create_source

Expand Down Expand Up @@ -234,6 +234,8 @@ async def create_spo_source(
tenant_name="test",
client_id="2",
secret_value="3",
certificate=None,
private_key=None,
auth_method="secret",
site_collections=WILDCARD,
use_document_level_security=False,
Expand All @@ -248,6 +250,8 @@ async def create_spo_source(
tenant_id=tenant_id,
client_id=client_id,
secret_value=secret_value,
certificate=certificate,
private_key=private_key,
tenant_name=tenant_name,
site_collections=site_collections,
use_document_level_security=use_document_level_security,
Expand Down Expand Up @@ -2991,16 +2995,64 @@ async def test_download_function_with_filtering_rule(self):
async with create_spo_source() as source:
max_drive_item_age = 15
drive_item = {
"name": "test",
"lastModifiedDateTime": str(
"name": "test.txt",
"@microsoft.graph.downloadUrl": "http://localhost/filename",
"lastModifiedDateTime": (
datetime.utcnow() - timedelta(days=max_drive_item_age + 1)
),
).strftime(ISO_ZULU_TIMESTAMP_FORMAT),
}

download_result = source.download_function(drive_item, max_drive_item_age)

assert download_result is None

@pytest.mark.asyncio
async def test_download_function_for_file_with_no_lastModifiedDatetTime(self):
async with create_spo_source() as source:
max_drive_item_age = 15
drive_item = {
"name": "test.txt",
"@microsoft.graph.downloadUrl": "http://localhost/filename",
}

download_result = source.download_function(drive_item, max_drive_item_age)

assert download_result is None

@pytest.mark.asyncio
async def test_download_function_for_too_large_file(self):
async with create_spo_source() as source:
max_drive_item_age = 15
drive_item = {
"name": "test.txt",
"@microsoft.graph.downloadUrl": "http://localhost/filename",
"size": 5 * 1024 * 1024 * 1024,
"lastModifiedDateTime": (
datetime.now(timezone.utc) - timedelta(days=max_drive_item_age - 5)
).strftime(ISO_ZULU_TIMESTAMP_FORMAT),
}

download_result = source.download_function(drive_item, max_drive_item_age)

assert download_result is None

@pytest.mark.asyncio
async def test_download_function_for_recently_changed_file(self):
async with create_spo_source() as source:
max_drive_item_age = 15
drive_item = {
"name": "test.txt",
"@microsoft.graph.downloadUrl": "http://localhost/filename",
"size": 5000,
"lastModifiedDateTime": (
datetime.now(timezone.utc) - timedelta(days=max_drive_item_age - 5)
).strftime(ISO_ZULU_TIMESTAMP_FORMAT),
}

download_result = source.download_function(drive_item, max_drive_item_age)

assert download_result is not None

def test_get_default_configuration(self):
config = SharepointOnlineDataSource.get_default_configuration()

Expand Down Expand Up @@ -3053,6 +3105,21 @@ async def test_validate_config(self, patch_sharepoint_client):
patch_sharepoint_client.rest_api_token.get.assert_awaited()
patch_sharepoint_client.site_collections.assert_not_called()

@pytest.mark.asyncio
async def test_correct_tokens_are_set_when_certificates_are_used(self):
private_key = "opens_all_locks"
certificate = "its_certified"
async with create_spo_source(
auth_method="certificate",
secret_value=None,
private_key=private_key,
certificate=certificate,
) as source:
client = source.client

assert isinstance(client.graph_api_token, EntraAPIToken)
assert isinstance(client.rest_api_token, EntraAPIToken)

@pytest.mark.asyncio
async def test_validate_config_when_invalid_tenant(self, patch_sharepoint_client):
invalid_tenant_name = "wat"
Expand Down