Make CI run agent tests too for now#2806
Merged
artem-shelkovnikov merged 6 commits intomainfrom Sep 13, 2024
Merged
Conversation
seanstory
approved these changes
Sep 9, 2024
seanstory
requested changes
Sep 9, 2024
Member
seanstory
left a comment
seanstory
left a comment
There was a problem hiding this comment.
I had approved, but realized separately that this module didn't have an __init__.py file. When I added it, it suddenly broke coverage for make test. We may need to find a way to separate the coverage settings between these two targets, and that should probably be introduced as part of this PR. See: #2811
artem-shelkovnikov
force-pushed
the
artem/add-agent-tests-to-ci
branch
from
8e3c507 to
f9750d1
Compare
seanstory
reviewed
Sep 10, 2024
Comment on lines
27
to
29
| install-agent: install | ||
| .venv/bin/pip install -r requirements/agent.txt | ||
|
|
Member
There was a problem hiding this comment.
I vote we leave this, but just have it alias to .venv/bin/elastic-ingest for now. That way the agent code doesn't need to be changed again, and we have a place we can hook into in the future for agent-specific bits when we need/want them. Like:
install-agent: .venv/bin/elastic-ingest
# nothing here
WDYT?
Member
Author
There was a problem hiding this comment.
Sure, just added it back in last commit
seanstory
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/search-team/issues/8207
With this change CI will run tests for the agent component along with regular tests. That'll help us find issues with protobuf bumps and general problems with components and prevent merging broken changes to main.
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)