fix beats test failure

[kvalliyurnatt]

With the latest 8.17.0-SNAPSHOT build of beats, seems like "-system.hostfs=/hostfs" does not work, we need it to be "--system.hostfs=/hostfs"

Beats PR: elastic/beats#41277

[thbkrkr]

buildkite test this -f p=gke,s=8.17.0-SNAPSHOT -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

[naemono]

Wait, don't we need to version gate these changes depending on the version of beats we're testing? Won't this fail on older beats versions @kvalliyurnatt ?

[kvalliyurnatt]

@naemono I tested this on 8.16.0 locally and -- seems to be compatible

docker run --rm -ti docker.elastic.co/beats/metricbeat:8.16.0-SNAPSHOT -e --system.hostfs=/hostfs

[naemono]

@naemono I tested this on 8.16.0 locally and -- seems to be compatible

docker run --rm -ti docker.elastic.co/beats/metricbeat:8.16.0-SNAPSHOT -e --system.hostfs=/hostfs

We support the latest 7.x version, and the latest 6.x version in our e2e tests, and I suspect this will break those.

[naemono]

Well, a quick test of 6.8.23 and 7.17.25 locally seems to work, so maybe I'm wrong here.

[kvalliyurnatt]

Well, a quick test of 6.8.23 and 7.17.25 locally seems to work, so maybe I'm wrong here.

I did the same, it seems to work. seems like -- was always supported

[naemono]

In the case of this working for previous versions, 👍

[kvalliyurnatt]

buildkite test this -f p=gke -m s=8.16.0,s=7.17.25,s=6.8.23 -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

[naemono]

buildkite test this -f p=gke,s=8.16.0,s=7.17.25,s=6.8.23 -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

[thbkrkr]

buildkite test this -f p=gke,E2E_TAGS=beat -m s=8.16.0,s=7.17.25,s=6.8.23

---

buildkite test this -f p=gke -m s=8.16.0,s=7.17.25,s=6.8.23 -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

== buildkite test this -f p=gke -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

@kvalliyurnatt You should not use -m,--mixed multiple times in the same invocation, only the last one is used.

buildkite test this -f p=gke,s=8.16.0,s=7.17.25,s=6.8.23 -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

== buildkite test this -f p=gke,s=6.8.23 -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

@naemono You should not declare different values for the same variable in -f,--fixed, only the last one is used.

---

Reminder:

buildkite test this -f var1=x,var2=x,.. -m var=x1,var=x2,..

• fixed variables need to be different: var1=..,var2=..
• mixed variables can be the same with different values: var=x1,var=x2

[kvalliyurnatt]

buildkite test this -f p=gke,E2E_TAGS=beat -m s=8.16.0,s=7.17.25,s=6.8.23

buildkite test this -f p=gke -m s=8.16.0,s=7.17.25,s=6.8.23 -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

== buildkite test this -f p=gke -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

@kvalliyurnatt You should not use -m,--mixed multiple times in the same invocation, only the last one is used.

buildkite test this -f p=gke,s=8.16.0,s=7.17.25,s=6.8.23 -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

== buildkite test this -f p=gke,s=6.8.23 -m t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

@naemono You should not declare different values for the same variable in -f,--fixed, only the last one is used.

Reminder:

buildkite test this -f var1=x,var2=x,.. -m var=x1,var=x2,..

• fixed variables need to be different: var1=..,var2=..
• mixed variables can be the same with different values: var=x1,var=x2

got it, thanks @thbkrkr

So something like. this would have worked ?

test this -f p=gke -m s=8.16.0,s=7.17.25,s=6.8.23,t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

[thbkrkr]

test this -f p=gke -m s=8.16.0,s=7.17.25,s=6.8.23,t=TestMetricbeatDefaultConfig,t=TestBeatKibanaRef

Not exactly, it would run 5 testsuites in //:

• test this -f p=gke,s=8.16.0 # run all tests on gke in 8.16.0
• test this -f p=gke,s=7.17.25 # run all tests on gke in 7.17.25
• test this -f p=gke,s=6.8.23 # run all tests on gke in 6.8.23
• test this -f p=gke,t=TestMetricbeatDefaultConfig # run TestMetricbeatDefaultConfig on gke in current stack version
• test this -f p=gke,t=TestBeatKibanaRef # run TestBeatKibanaRef on gke in current stack version

[thbkrkr]

buildkite test this -f p=gke,E2E_TAGS=beat -m s=6.8.23,s=7.17.25,s=8.16.0-SNAPSHOT

We live in the future, 8.16.0 is not released yet :)