Skip to content

[DOC] Mention base_path change in 2.8.0 release notes#6844

Merged
barkbay merged 6 commits intoelastic:mainfrom
barkbay:docs/6702
May 26, 2023
Merged

[DOC] Mention base_path change in 2.8.0 release notes#6844
barkbay merged 6 commits intoelastic:mainfrom
barkbay:docs/6702

Conversation

@barkbay
Copy link
Contributor

@barkbay barkbay commented May 23, 2023

Fixes #6702

@barkbay barkbay added >docs Documentation v2.8.0 labels May 23, 2023
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this a "breaking" change?

@barkbay barkbay requested a review from thbkrkr May 23, 2023 08:53
@barkbay
Copy link
Contributor Author

barkbay commented May 23, 2023

LGTM. Is this a "breaking" change?

Only if user attempted to set it in the past, and forgot it is set while it's actually not used by the current version of ECK. In such a case, upgrading to 2.8.0 will enable this setting which was ignored until then. I don't think it is a breaking change, @thbkrkr what do you think?

@thbkrkr
Copy link
Contributor

thbkrkr commented May 25, 2023

I don't think it is a breaking change, @thbkrkr what do you think?

I'd say it's not a breaking change because we don't break anything if you don't make a mistake but if you do, it will break you. I'd therefore be on the side of caution and I'll present this change as a breaking change.

@barkbay
Copy link
Contributor Author

barkbay commented May 25, 2023

Thanks @thbkrkr, I'll add a breaking change in the changelog.

@barkbay
Copy link
Contributor Author

barkbay commented May 25, 2023

@thbkrkr I also took advantage of this PR to regenerate docs/release-notes/2.8.0.asciidoc in order to minimize the number of backports. Let me know if it's ok for you. Thanks!

@barkbay
Copy link
Contributor Author

barkbay commented May 25, 2023

@elasticmachine run elasticsearch-ci/docs

Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Sorry if I'm a bit late but I think we should rename "Copy Elasticsearch configuration files before creating links" #6703 in something like "Hardened Security Context for Elasticsarch".

I think there are people who only read the release notes and not the highlights.

@barkbay
Copy link
Contributor Author

barkbay commented May 25, 2023

buildkite test this

@barkbay
Copy link
Contributor Author

barkbay commented May 25, 2023

I think docs failure is related to elastic/apm-server#10891?

@barkbay
Copy link
Contributor Author

barkbay commented May 26, 2023

@elasticmachine run elasticsearch-ci/docs

@barkbay barkbay merged commit 9573b93 into elastic:main May 26, 2023
@barkbay barkbay deleted the docs/6702 branch May 26, 2023 05:58
barkbay added a commit to barkbay/cloud-on-k8s that referenced this pull request May 26, 2023
* [DOC] Mention base_path change in 2.8.0 release notes

* Tag 6689 as a breaking change

* Regenerate docs/release-notes/2.8.0.asciidoc
barkbay added a commit that referenced this pull request May 26, 2023
* [DOC] Mention base_path change in 2.8.0 release notes

* Tag 6689 as a breaking change

* Regenerate docs/release-notes/2.8.0.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs Documentation v2.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mention #6689 in 2.8 release notes

3 participants