Skip to content

Update Logstash Stack Monitoring unit tests#6741

Merged
thbkrkr merged 1 commit intoelastic:mainfrom
thbkrkr:fix-unit-integ-tests
Apr 28, 2023
Merged

Update Logstash Stack Monitoring unit tests#6741
thbkrkr merged 1 commit intoelastic:mainfrom
thbkrkr:fix-unit-integ-tests

Conversation

@thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Apr 28, 2023

Because we don't test PRs with an automatic merge of the main branch, we missed that the tests in #6732 had to be updated to take into account the changes made by #6703, which adds a new temp volume to the Beats sidecars:

tmpVolume := volume.NewEmptyDirVolume(
esvolume.TempVolumeName,
esvolume.TempVolumeMountPath,
)

@thbkrkr thbkrkr added >bug Something isn't working >test Related to unit/integration/e2e tests exclude-from-release-notes Exclude this PR from appearing in the release notes v2.8.0 labels Apr 28, 2023
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr thbkrkr merged commit e679b5f into elastic:main Apr 28, 2023
@thbkrkr thbkrkr deleted the fix-unit-integ-tests branch May 10, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug Something isn't working exclude-from-release-notes Exclude this PR from appearing in the release notes :logstash >test Related to unit/integration/e2e tests v2.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants