Update module sigs.k8s.io/controller-runtime to v0.10.0

[renovate]

This PR contains the following updates:

Package	Type	Update	Change
sigs.k8s.io/controller-runtime	require	minor	v0.9.6 -> v0.10.0

---

Release Notes

kubernetes-sigs/controller-runtime

v0.10.0

Compare Source

Controller-runtime v0.10.0

Changes since v0.9.6

⚠️ Breaking Changes

• Client: Ensure no stale data remains in target object (#​1640)
• bump to kubernetes 1.22.0 (#​1626)
• Disable the rest_client_request_latency_seconds metric by default (#​1587)
• Fakeclient: Reject Delete with mismatched ResourceVersion (#​1582)

✨ New Features

• Construct the typed clients we need (#​1637)
• Add UnsafeDisableDeepCopy into cache option to avoid deep copy during get/list (#​1274)
• Add an option to recover panic for controller reconcile (#​1627)
• chore: Fix bad urls (#​1632)
• Update Kubernetes dependencies to v0.21.3 (#​1604)
• Restrict namespace for list/watch based on field selectors (#​1602)
• add health check for webhook server (#​1588)

🐛 Bug Fixes

• Envtest should try to allocate a port for etcd listenPeerURL (#​1612)
• Fix a bug with Limit list opt returning less than expected number of objects in the result. (#​1618)
• fix webhook health check tls handshake timeouts (#​1617)
• fix the typo of certwatcher example test (#​1615)
• Use non blocking file locking for flock library (#​1605)

📖 Documentation

• Update doc.go (#​1597)
• add godoc badge to README (#​1596)
• Remove extraneous "s" in pkg/events in GoDoc (#​1466)
• tmp-logging - fix markdown parsing error (#​1584)

🌱 Others

• Manager should use the global logger, reduce log names verbosity (#​1647)
• Update dependencies August 2021 (#​1635)
• Disable fsync on etcd envtest (#​1629)
• OWNERS_ALIASES: move joelanford to maintainers (#​1624)
• cleanup Use objectutil IsAPINamespaced (#​1573)
• Update k8s.io/* dependencies to 0.22.1 (#​1646)
• Add varshaprasad96 as reviewer (#​1614)

Thanks to all our contributors! 😊

---

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box.

---

This PR has been generated by WhiteSource Renovate. View repository job log here.

[thbkrkr]

kubernetes-sigs/controller-runtime#1582 "Fakeclient: Reject Delete with mismatched ResourceVersion " impacts 2 unit tests:

pkg/controller/elasticsearch/driver.TestUpgradePodsDeletion_WithNodeTypeMutations
pkg/controller/elasticsearch/driver.TestUpgradePodsDeletion_Delete

I was wondering why the tests fails with a resource version set to 999? It's because the fake client set 999 if there is no resource version: https://github.com/kubernetes-sigs/controller-runtime/blob/81309dc8a4f8809f067bf9fcc3d7d012d7cee8c5/pkg/client/fake/client.go#L165-L170.

I propose to always set a default resource version in the pods used in the tests: c82ec1b.

[thbkrkr]

Jenkins test this please

[thbkrkr]

11:27:54  === �[31mFAIL�[0m: pkg/controller/license  (0.00s)
11:27:54  {"log.level":"debug","@timestamp":"2021-09-02T09:26:55.253Z","log.logger":"controller-runtime.test-env","message":"starting control plane","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0"}
11:27:54  {"log.level":"debug","@timestamp":"2021-09-02T09:27:16.006Z","log.logger":"controller-runtime.test-env","message":"installing CRDs","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0"}
11:27:54  {"log.level":"debug","@timestamp":"2021-09-02T09:27:16.006Z","log.logger":"controller-runtime.test-env","message":"reading CRDs from path","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0","path":"../../../config/crds/v1beta1"}
11:27:54  {"log.level":"debug","@timestamp":"2021-09-02T09:27:16.833Z","log.logger":"controller-runtime.test-env","message":"read CRDs from file","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0","file":"all-crds.yaml"}
11:27:54  {"log.level":"debug","@timestamp":"2021-09-02T09:27:16.997Z","log.logger":"controller-runtime.test-env","message":"installing CRD","service.version":"0.0.0-SNAPSHOT+00000000","service.type":"eck","ecs.version":"1.4.0","crd":"agents.agent.k8s.elastic.co"}
11:27:54  failed to start test environment (attempt 1/1): unable to install CRDs onto control plane: unable to create CRD instances: unable to create CRD "agents.agent.k8s.elastic.co": CustomResourceDefinition.apiextensions.k8s.io "agents.agent.k8s.elastic.co" is invalid: spec.versions[0].schema.openAPIV3Schema: Required value: schemas are required
11:27:54  failed to start test environment after 1 attempts, exiting.
11:27:54  FAIL	github.com/elastic/cloud-on-k8s/pkg/controller/license	21.938s

Due to the upgrade to k8s 1.22.

[thbkrkr]

Jenkins test this please

[thbkrkr]

So we have 2 changes associated with this upgrade:

• c82ec1b Set default resource version in tests
• 1d86466 Use v1 CRDs in integration tests

[thbkrkr]

@elasticmachine run elasticsearch-ci/docs