Avoid panic on Kibana telemetry API call #3736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under unknown conditions, the Kibana telemetry API call may return an empty response and causes a panic. This commit fixes this by retrying the call until the slice is not empty.
|
Might also be worth opening a kibana issue if non-error responses are always supposed to have a body? |
barkbay
approved these changes
Sep 9, 2020
I'm going to reach Kibana folks and see if it's worth opening an issue as I'm not comfortable opening it without being able to repro it. |
|
There is a change in the Kibana's startup behaviour that can lead to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under unknown conditions, the Kibana telemetry API call may return an empty response and
causes a panic. This commit fixes this by retrying the call until the slice is not empty.
Resolves #3709.