-
Notifications
You must be signed in to change notification settings - Fork 5k
Convert Filebeat iis.error to ECS and add IPv6 zone support for IIS access logs #9955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
jenkins, test this |
|
@ruflin ready for a review. Only Jenkins failures are flaky tests unrelated to Filebeat |
|
I filed an issue here for the flaky test: #9987 |
dc9784e to
857a183
Compare
|
Rebased to fix a conflict. This reminded me that in migrating
I've also updated the PR title to reflect this. @ruflin Ok with killing two birds with one PR? ;-) |
ruflin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I resolved the changelog conflict.
|
Thanks for adding the IPv6 support to the access fileset too, this part would need to be backported as has been done with #9869. |
|
@jsoriano Yes, noted. I'll do that later today. The backport will cover the support for zone in the IP address, but will not introduce the Shall I create a brand new PR just for this on 6.x, and then backport to 6.6 as well, for 6.6.1? Or should I hold off for 6.6? I'm unsure about the exact timing of the procedure :-) |
c2ac4cd to
9a1c851
Compare
9a1c851 to
3cf462e
Compare
4429c66 to
31db36f
Compare
Caveats
.addressfield to keep the raw address around, and.ipfield is only set with the IP value without the zone.Renames
Alias adjustments in iis.access
.ip).ip)TODO
.addressfields