Update magefile/mage to v1.8.0#9769
Merged
andrewkroh merged 2 commits intoelastic:masterfrom Jan 2, 2019
Merged
Conversation
Vendor github.com/magefile/mage version v1.8.0 (aedfce64c122eef47009b7f80c9771044753215d).
This was a work-around I added, but now mage has first class support for this.
ruflin
approved these changes
Dec 24, 2018
Contributor
ruflin
left a comment
There was a problem hiding this comment.
Could we potentially backport this to 6.x as I expect most development will happen now in 6.x and master. So change of branch should become less of a problem?
ph
approved these changes
Dec 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendor github.com/magefile/mage version v1.8.0 (aedfce64c122eef47009b7f80c9771044753215d).
I updated the
make magetarget to detect the mage version and automatically upgradeUpgrade benefits:
// mage:import [namespace].TODO:
makelogic to re-install mage if the version is wrong (e.g. downgrade automatically).packageon non-Linux. This is because the new mage version added-goosand-goarchflags for use with-compileand no longer honors theGOOSandGOARCHwhen pre-compiling a mage binary that targets Linux for use inside the container.