Skip to content

[Auditbeat] Set auditbeat.max_start_delay to 0 for system tests#9500

Merged
cwurm merged 1 commit intoelastic:masterfrom
cwurm:auditbeat_tests_start_delay
Dec 12, 2018
Merged

[Auditbeat] Set auditbeat.max_start_delay to 0 for system tests#9500
cwurm merged 1 commit intoelastic:masterfrom
cwurm:auditbeat_tests_start_delay

Conversation

@cwurm
Copy link
Copy Markdown
Contributor

@cwurm cwurm commented Dec 11, 2018

Setting auditbeat.max_start_delay: 0 for system tests greatly reduces their execution time.

Before:

----------------------------------------------------------------------
XML: /home/vagrant/go/src/github.com/elastic/beats/auditbeat/build/TEST-system.xml
[success] 39.25% test_file_integrity.Test.test_recursive: 8.7114s
[success] 30.10% test_show_command.Test.test_show_auditd_rules: 6.6808s
[success] 29.18% test_file_integrity.Test.test_non_recursive: 6.4772s
[success] 0.77% test_base.Test.test_start_stop: 0.1703s
[success] 0.50% test_show_command.Test.test_show_auditd_status: 0.1113s
[success] 0.20% test_show_command.Test.test_show_command: 0.0448s
----------------------------------------------------------------------
Ran 8 tests in 22.204s

The time varies since the startup time is random, but it's usually above 10s.

After:

----------------------------------------------------------------------
XML: /home/vagrant/go/src/github.com/elastic/beats/auditbeat/build/TEST-system.xml
[success] 42.51% test_file_integrity.Test.test_recursive: 1.3856s
[success] 40.13% test_file_integrity.Test.test_non_recursive: 1.3081s
[success] 10.25% test_show_command.Test.test_show_auditd_rules: 0.3342s
[success] 4.73% test_base.Test.test_start_stop: 0.1543s
[success] 1.21% test_show_command.Test.test_show_auditd_status: 0.0395s
[success] 1.17% test_show_command.Test.test_show_command: 0.0382s
----------------------------------------------------------------------
Ran 8 tests in 3.268s

@webmat
Copy link
Copy Markdown
Contributor

webmat commented Dec 12, 2018

Restarted the single failing Travis CI test, and it passed.

@cwurm cwurm merged commit 7a2cf0f into elastic:master Dec 12, 2018
@cwurm cwurm deleted the auditbeat_tests_start_delay branch December 12, 2018 19:31
cwurm pushed a commit that referenced this pull request Dec 12, 2018
Setting `auditbeat.max_start_delay: 0` for system tests greatly reduces their execution time.

(cherry picked from commit 7a2cf0f)
cwurm pushed a commit to cwurm/beats that referenced this pull request Dec 16, 2018
…stic#9500)

Setting `auditbeat.max_start_delay: 0` for system tests greatly reduces their execution time.

(cherry picked from commit 7a2cf0f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants