Use log.source.address instead of log.source.ip for network inputs#9487
Merged
jsoriano merged 5 commits intoelastic:masterfrom Dec 14, 2018
Merged
Use log.source.address instead of log.source.ip for network inputs#9487jsoriano merged 5 commits intoelastic:masterfrom
jsoriano merged 5 commits intoelastic:masterfrom
Conversation
Sources for network inputs can be of the form host:port, what cannot be stored in ip fields.
jsoriano
added
bug
review
Filebeat
Contributor
|
Pinging @elastic/infrastructure |
ruflin
reviewed
Dec 11, 2018
dev-tools/ecs-migration.yml
Outdated
| to: ["log.file.path", "log.source.ip"] | ||
| to: | ||
| - log.file.path | ||
| - log.source.ip |
Contributor
There was a problem hiding this comment.
I assume we can remove log.source.ip from this list?
Member
Author
There was a problem hiding this comment.
Not sure, I kept it in case it was being used, or was going to be used in other places, but I have no problem with removing it.
Contributor
There was a problem hiding this comment.
It "should" not be used anywhere else. Can you also do a quick search to make sure this is the case and remove it?
Member
Author
There was a problem hiding this comment.
Should I also remove it from fields.common.yml?
ruflin
reviewed
Dec 11, 2018
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
Change LGTM. I think you need to adjust tests in a few places to make CI happy.
ruflin
approved these changes
Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sources for network inputs can be of the form host:port, what cannot be
stored in ip fields.
Replaces #9460