Skip to content

Conversation

@ruflin
Copy link
Collaborator

@ruflin ruflin commented Dec 10, 2018

No description provided.

@ruflin ruflin added review ecs Team:Integrations Label for the Integrations team labels Dec 10, 2018
@ruflin ruflin self-assigned this Dec 10, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/infrastructure

@ruflin ruflin requested a review from webmat December 10, 2018 08:52
@ruflin ruflin force-pushed the migrate-add-locale branch from 733951e to 2fb4d15 Compare December 10, 2018 08:52
@ruflin ruflin mentioned this pull request Dec 10, 2018
@ruflin ruflin force-pushed the migrate-add-locale branch from 9dfb53b to 63d96cc Compare December 12, 2018 15:16
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than a very minor nitpick. You'll want to address it now, to avoid an unnecessary conflict with PR #9283 :-)

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruflin ruflin force-pushed the migrate-add-locale branch 2 times, most recently from 3ca328f to 11afc90 Compare December 13, 2018 13:36
@ruflin ruflin force-pushed the migrate-add-locale branch from 11afc90 to 3e5b7b8 Compare December 13, 2018 13:39
@ruflin ruflin merged commit 4f0a65f into elastic:master Dec 13, 2018
@ruflin ruflin deleted the migrate-add-locale branch December 13, 2018 15:20
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
droberts195 pushed a commit to droberts195/elasticsearch that referenced this pull request Feb 24, 2020
This is because beat.timezone was renamed to event.timezone in
elastic/beats#9458
droberts195 pushed a commit to elastic/kibana that referenced this pull request Feb 25, 2020
This is because beat.timezone was renamed to event.timezone in
elastic/beats#9458

The corresponding file structure finder change is
elastic/elasticsearch#52720
droberts195 pushed a commit to elastic/elasticsearch that referenced this pull request Feb 25, 2020
)

This is because beat.timezone was renamed to event.timezone in
elastic/beats#9458
droberts195 pushed a commit to elastic/elasticsearch that referenced this pull request Feb 25, 2020
)

This is because beat.timezone was renamed to event.timezone in
elastic/beats#9458
droberts195 pushed a commit to elastic/kibana that referenced this pull request Feb 25, 2020
…) (#58463)

This is because beat.timezone was renamed to event.timezone in
elastic/beats#9458

The corresponding file structure finder change is
elastic/elasticsearch#52720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ecs review Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants