Skip to content

[Packetbeat] Restructure client/server and process fields#9303

Merged
andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh:feature/pb/ecs-process-fields
Dec 12, 2018
Merged

[Packetbeat] Restructure client/server and process fields#9303
andrewkroh merged 1 commit intoelastic:masterfrom
andrewkroh:feature/pb/ecs-process-fields

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Nov 30, 2018

NOTE: Review the second commit to because this is based on #9121 (change flow fields) which has not been merged yet.

This is part of #7968.

Sample HTTP Event with Process metadata

Changed

  • client_ip - client.ip (changed to ip type)
  • client_port - client.port
  • client_server - client.domain
  • client_proc - client.process.name
  • client_cmdline - client.process.args (changed to an array)
  • direction - network.direction
  • ip - server.ip (changed to ip type)
  • port - server.port
  • server - server.domain
  • proc - server.process.name
  • cmdline - server.process.args (change to an array)

Added

  • client.process.executable
  • client.process.working_directory
  • client.process.pid
  • client.process.ppid
  • client.process.start
  • server.process.executable
  • server.process.working_directory
  • server.process.pid
  • server.process.ppid
  • server.process.start

The top-level process field is populated with the server.process
or client.process (server takes priority). Likewise for flows process
is populated with the destination.process or the client.process
(destination takes priority).

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/secops

Copy link
Copy Markdown
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh force-pushed the feature/pb/ecs-process-fields branch 2 times, most recently from cb85be3 to 5936e45 Compare December 10, 2018 23:56
Changed

- client_ip - client.ip (changed to ip type)
- client_port - client.port
- client_server - client.domain
- client_proc - client.process.name
- client_cmdline - client.process.args (changed to an array)
- direction - network.direction
- ip - server.ip (changed to ip type)
- port - server.port
- server - server.domain
- proc - server.process.name
- cmdline - server.process.args (change to an array)

Added

- client.process.executable
- client.process.working_directory
- client.process.pid
- client.process.ppid
- client.process.start
- server.process.executable
- server.process.working_directory
- server.process.pid
- server.process.ppid
- server.process.start

The top-level `process` field is populated with the `server.process`
or `client.process` (server takes priority). Likewise for flows `process`
is populated with the `destination.process` or the `client.process`
(destination takes priority).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants