Skip to content

Force pull of images on make start-environment #8230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsoriano merged 2 commits into from
Sep 6, 2018
Merged

Force pull of images on make start-environment #8230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5692d01
Force pull of images on `make start-environment`
jsoriano Sep 4, 2018
5171030
Merge remote-tracking branch 'origin/master' into start-environment-pull
jsoriano Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libbeat/scripts/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ build-image: write-environment
# To use it for running the test, set ES_HOST and REDIS_HOST environment variable to the ip of your docker-machine.
.PHONY: start-environment
start-environment: stop-environment
${DOCKER_COMPOSE} pull --include-deps
Copy link
Copy Markdown
Contributor

@ruflin ruflin Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this will use the cached layers if they are available and identical?

Copy link
Copy Markdown
Member Author

@jsoriano jsoriano Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it still reuses local layers.

Copy link
Copy Markdown
Member Author

@jsoriano jsoriano Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I see build times increased some minutes... maybe this is normal if we were re-using images too much.

Copy link
Copy Markdown
Contributor

@ruflin ruflin Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its ok as it gets us on the same page with travis. also if intermediary images used, the increase should only be once a day

${DOCKER_COMPOSE} up -d

.PHONY: stop-environment
Expand Down