Improve error catching for recursiveWatcher #8087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been spurious test failures in test_file_integrity.Test.test_recursive (elastic#7731). This makes sure all errors encountered in recursiveWatcher are caught and logged, and also adds a debug message when a new recursive watch is added.
andrewkroh
approved these changes
Aug 27, 2018
Contributor
|
@cwurm I hit the error agai here: https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/6383/beat=auditbeat,label=ubuntu/testReport/junit/test_file_integrity/Test/test_recursive/ It's against 6.x. I would suggest to backport this fix also to 6.x? |
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
Sep 18, 2018
There have been spurious test failures in test_file_integrity.Test.test_recursive (elastic#7731). This makes sure all errors encountered in recursiveWatcher are caught and logged, and also adds a debug message when a new recursive watch is added. (cherry picked from commit e5f16e2)
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been spurious test failures in test_file_integrity.Test.test_recursive (#7731).
This makes sure all errors encountered in recursiveWatcher are caught and logged, and also adds a debug message when a new recursive watch is added.