Skip to content

[libbeat] aws auth method: fix service name and region overwrite#47712

Merged
khushijain21 merged 1 commit intoelastic:mainfrom
moukoublen:fix_aws_auth_overwrite
Nov 19, 2025
Merged

[libbeat] aws auth method: fix service name and region overwrite#47712
khushijain21 merged 1 commit intoelastic:mainfrom
moukoublen:fix_aws_auth_overwrite

Conversation

@moukoublen
Copy link
Copy Markdown
Member

@moukoublen moukoublen commented Nov 19, 2025

Proposed commit message

Fix the service name and region overwrite when values are set in the input configuration in the aws auth method that was introduced here.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@moukoublen moukoublen requested a review from a team as a code owner November 19, 2025 09:32
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 19, 2025
@botelastic
Copy link
Copy Markdown

botelastic Bot commented Nov 19, 2025

This pull request doesn't have a Team:<team> label.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@moukoublen moukoublen requested a review from efd6 November 19, 2025 09:32
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Nov 19, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @moukoublen? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@moukoublen moukoublen added backport-skip Skip notification from the automated backport with mergify skip-changelog bug labels Nov 19, 2025
Copy link
Copy Markdown
Contributor

@khushijain21 khushijain21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khushijain21 khushijain21 merged commit 183016c into elastic:main Nov 19, 2025
113 of 114 checks passed
andrzej-stencel pushed a commit to andrzej-stencel/beats that referenced this pull request Dec 1, 2025
olegsu added a commit to olegsu/beats that referenced this pull request Apr 9, 2026
…tic#47712)

Cherry-picks signer.go and signer_test.go fixes from main commit 183016c.

Original PR: elastic#47712
olegsu added a commit to olegsu/beats that referenced this pull request Apr 9, 2026
…tic#47712)

Cherry-picks signer.go and signer_test.go fixes from main commit 183016c.

Original PR: elastic#47712
@olegsu
Copy link
Copy Markdown

olegsu commented Apr 16, 2026

@Mergifyio backport 8.19

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 16, 2026

backport 8.19

✅ Backports have been created

Details

Cherry-pick of 183016c has failed:

On branch mergify/bp/8.19/pr-47712
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 183016ce9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x-pack/libbeat/common/aws/signer.go
	modified:   x-pack/libbeat/common/aws/signer_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/libbeat/common/aws/credentials_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify Bot pushed a commit that referenced this pull request Apr 16, 2026
)

(cherry picked from commit 183016c)

# Conflicts:
#	x-pack/libbeat/common/aws/credentials_test.go
olegsu added a commit that referenced this pull request Apr 16, 2026
The 8.19 branch already used assert.True (cleaner form) while the
cherry-pick from main used assert.Equal(t, true, ...). Both add the
same //nolint:errcheck comments. Keep the HEAD (8.19) assert.True form.

Closes conflict from: cherry-pick 183016c
Backport of: #47712
PR: #50155
olegsu added a commit that referenced this pull request Apr 16, 2026
…nd region overwrite (#50155)

* [libbeat] aws auth method: fix service name and region overwrite (#47712)

(cherry picked from commit 183016c)

# Conflicts:
#	x-pack/libbeat/common/aws/credentials_test.go

* Resolve conflict in credentials_test.go for #47712 backport

The 8.19 branch already used assert.True (cleaner form) while the
cherry-pick from main used assert.Equal(t, true, ...). Both add the
same //nolint:errcheck comments. Keep the HEAD (8.19) assert.True form.

Closes conflict from: cherry-pick 183016c
Backport of: #47712
PR: #50155

---------

Co-authored-by: Kostas Stamatakis <moukoublen@gmail.com>
Co-authored-by: Oleg Sucharevich <oleg.sucharevich@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify bug needs_team Indicates that the issue/PR needs a Team:* label skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants