refactor: replace lopg.ObserverLogs with logptest by kruskall · Pull Request #45734 · elastic/beats

kruskall · 2025-08-04T21:21:47Z

Proposed commit message

ObserverLogs is relying on a testing package in a non-test package

move to logptest

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

[ ]

How to test this PR locally

Related issues

depends on Replace global loggers with local logger #13 #45720

Use cases

Screenshots

Logs

ObserverLogs is relying on a testing package in a non-test package move to logptest

github-actions · 2025-08-04T21:21:58Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2025-08-04T21:22:25Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

elasticmachine · 2025-08-05T08:45:40Z

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

elasticmachine · 2025-08-05T08:45:41Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine · 2025-08-05T08:45:41Z

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

khushijain21 · 2025-08-05T09:14:20Z

There are some places in beats codebase that use a very clumsy way of setting observer. Now that we have NewTestingLoggerWithObserver - could you also replace those parts?

This is one such instance https://github.com/khushijain21/beats/blob/localLogger13/libbeat/autodiscover/autodiscover_test.go#L759-L761

Thanks for doing this!

…verlogs

libbeat/processors/script/javascript/module/console/console_test.go

…verlogs

kruskall · 2025-09-04T00:08:21Z

@elastic/sec-linux-platform friendly ping for review

kruskall · 2025-09-23T23:36:44Z

@elastic/sec-linux-platform friendly ping for review

kruskall · 2025-10-08T22:24:36Z

@elastic/sec-linux-platform friendly ping for review

pierrehilbert · 2025-10-09T15:00:09Z

@nfritts could you please take a look here?

kruskall · 2025-11-04T16:46:20Z

@Mergifyio backport 8.19 9.1 9.2

mergify · 2025-11-04T16:46:35Z

backport 8.19 9.1 9.2

✅ Backports have been created

Details

#47463 [8.19](backport #45734) refactor: replace lopg.ObserverLogs with logptest has been created for branch 8.19 but encountered conflicts
#47462 [9.1](backport #45734) refactor: replace lopg.ObserverLogs with logptest has been created for branch 9.1 but encountered conflicts
#47464 [9.2](backport #45734) refactor: replace lopg.ObserverLogs with logptest has been created for branch 9.2

* refactor: replace lopg.ObserverLogs with logptest ObserverLogs is relying on a testing package in a non-test package move to logptest * lint: regenerate notice file * test: update to NewTestingLoggerWithObserver * lint: regenerate notice * lint: remove unused imports * lint: remove unused imports * Update console_test.go * lint: fix linter issues (cherry picked from commit b5789af) # Conflicts: # filebeat/input/journald/pkg/journalctl/reader_test.go

* refactor: replace lopg.ObserverLogs with logptest ObserverLogs is relying on a testing package in a non-test package move to logptest * lint: regenerate notice file * test: update to NewTestingLoggerWithObserver * lint: regenerate notice * lint: remove unused imports * lint: remove unused imports * Update console_test.go * lint: fix linter issues (cherry picked from commit b5789af) # Conflicts: # filebeat/input/filestream/config_test.go # filebeat/input/journald/pkg/journalctl/reader_test.go # libbeat/autodiscover/autodiscover_test.go

* refactor: replace lopg.ObserverLogs with logptest ObserverLogs is relying on a testing package in a non-test package move to logptest * lint: regenerate notice file * test: update to NewTestingLoggerWithObserver * lint: regenerate notice * lint: remove unused imports * lint: remove unused imports * Update console_test.go * lint: fix linter issues (cherry picked from commit b5789af)

* refactor: replace lopg.ObserverLogs with logptest ObserverLogs is relying on a testing package in a non-test package move to logptest * lint: regenerate notice file * test: update to NewTestingLoggerWithObserver * lint: regenerate notice * lint: remove unused imports * lint: remove unused imports * Update console_test.go * lint: fix linter issues (cherry picked from commit b5789af) Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>

…test (#47463) * refactor: replace lopg.ObserverLogs with logptest (#45734) * refactor: replace lopg.ObserverLogs with logptest ObserverLogs is relying on a testing package in a non-test package move to logptest * lint: regenerate notice file * test: update to NewTestingLoggerWithObserver * lint: regenerate notice * lint: remove unused imports * lint: remove unused imports * Update console_test.go * lint: fix linter issues (cherry picked from commit b5789af) # Conflicts: # filebeat/input/filestream/config_test.go # filebeat/input/journald/pkg/journalctl/reader_test.go # libbeat/autodiscover/autodiscover_test.go * Update config_test.go * Update autodiscover_test.go * Update reader_test.go * Update autodiscover_test.go --------- Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>

…est (#47462) * refactor: replace lopg.ObserverLogs with logptest (#45734) * refactor: replace lopg.ObserverLogs with logptest ObserverLogs is relying on a testing package in a non-test package move to logptest * lint: regenerate notice file * test: update to NewTestingLoggerWithObserver * lint: regenerate notice * lint: remove unused imports * lint: remove unused imports * Update console_test.go * lint: fix linter issues (cherry picked from commit b5789af) # Conflicts: # filebeat/input/journald/pkg/journalctl/reader_test.go * Update reader_test.go --------- Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>

* refactor: replace lopg.ObserverLogs with logptest ObserverLogs is relying on a testing package in a non-test package move to logptest * lint: regenerate notice file * test: update to NewTestingLoggerWithObserver * lint: regenerate notice * lint: remove unused imports * lint: remove unused imports * Update console_test.go * lint: fix linter issues

refactor: replace lopg.ObserverLogs with logptest

3e93eb8

ObserverLogs is relying on a testing package in a non-test package move to logptest

kruskall requested review from a team as code owners August 4, 2025 21:21

kruskall requested review from faec and mauri870 August 4, 2025 21:21

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 4, 2025

mergify bot assigned kruskall Aug 4, 2025

lint: regenerate notice file

aaded65

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 5, 2025

kruskall added 6 commits August 7, 2025 19:47

Merge remote-tracking branch 'upstream/main' into refactor/drop-obser…

1d5f3d5

…verlogs

test: update to NewTestingLoggerWithObserver

bdd5522

lint: regenerate notice

9d53c11

lint: remove unused imports

3034bba

lint: remove unused imports

0441cd5

Merge branch 'main' into refactor/drop-observerlogs

46ab6c5

khushijain21 reviewed Aug 8, 2025

View reviewed changes

libbeat/processors/script/javascript/module/console/console_test.go Show resolved Hide resolved

Update console_test.go

14a0f33

kruskall added 3 commits August 20, 2025 16:41

Merge remote-tracking branch 'upstream/main' into refactor/drop-obser…

aeb7c3f

…verlogs

Merge branch 'main' into refactor/drop-observerlogs

7e9f8a1

Merge branch 'main' into refactor/drop-observerlogs

372238a

mcapell approved these changes Aug 26, 2025

View reviewed changes

kruskall added 2 commits September 28, 2025 11:58

Merge branch 'main' into refactor/drop-observerlogs

a813527

lint: fix linter issues

b80ba18

faec approved these changes Oct 29, 2025

View reviewed changes

nfritts approved these changes Nov 4, 2025

View reviewed changes

kruskall merged commit b5789af into elastic:main Nov 4, 2025
207 of 210 checks passed

kruskall deleted the refactor/drop-observerlogs branch November 4, 2025 16:21

kruskall added backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch backport-9.2 Automated backport to the 9.2 branch labels Nov 4, 2025

This was referenced Nov 4, 2025

[9.1](backport #45734) refactor: replace lopg.ObserverLogs with logptest #47462

Merged

[8.19](backport #45734) refactor: replace lopg.ObserverLogs with logptest #47463

Merged

mergify bot mentioned this pull request Nov 4, 2025

[9.2](backport #45734) refactor: replace lopg.ObserverLogs with logptest #47464

Merged

6 tasks

pierrehilbert mentioned this pull request Nov 5, 2025

feat: deprecate observer output elastic/elastic-agent-libs#367

Merged

3 tasks

Conversation

kruskall commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

Disruptive User Impact

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Uh oh!

github-actions bot commented Aug 4, 2025

🤖 GitHub comments

Uh oh!

mergify bot commented Aug 4, 2025

Uh oh!

elasticmachine commented Aug 5, 2025

Uh oh!

elasticmachine commented Aug 5, 2025

Uh oh!

elasticmachine commented Aug 5, 2025

Uh oh!

khushijain21 commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kruskall commented Sep 4, 2025

Uh oh!

kruskall commented Sep 23, 2025

Uh oh!

kruskall commented Oct 8, 2025

Uh oh!

pierrehilbert commented Oct 9, 2025

Uh oh!

Uh oh!

kruskall commented Nov 4, 2025

Uh oh!

mergify bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kruskall commented Aug 4, 2025 •

edited

Loading

khushijain21 commented Aug 5, 2025 •

edited

Loading

mergify bot commented Nov 4, 2025 •

edited

Loading