x-pack/filebeat/input/gcppubsub: fix integration tests#45150
Merged
chemamartinez merged 6 commits intoelastic:mainfrom Jul 4, 2025
Merged
x-pack/filebeat/input/gcppubsub: fix integration tests#45150chemamartinez merged 6 commits intoelastic:mainfrom
chemamartinez merged 6 commits intoelastic:mainfrom
Conversation
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
belimawr
reviewed
Jul 2, 2025
Member
belimawr
left a comment
There was a problem hiding this comment.
Some tests are timing out, could you check if the're related to your change?
Contributor
Author
Thanks for bringing this up, the same tests were failing for agentbeat, I didn't realize agentbeat was also running filebeat integration tests. They should now pass. I've checked the other failing tests and they are unrelated. |
efd6
approved these changes
Jul 3, 2025
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
AndersonQ
approved these changes
Jul 4, 2025
Contributor
|
@Mergifyio backport 9.0 9.1 |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
Solved two issues in the GCP Pub/Sub input tests: - GCP Pub/Sub Emulator Container Missing: this has been fixed by ensuring the Pub/Sub emulator Docker container is properly launched for the test environment. - Fix for Segfault in NewInput.func2: a segmentation fault occurred when test code accessed in.metrics before it was initialized. Metrics are now explicitly initialized in the test setup to avoid nil pointer dereferencing. (cherry picked from commit 5373f23)
mergify Bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
Solved two issues in the GCP Pub/Sub input tests: - GCP Pub/Sub Emulator Container Missing: this has been fixed by ensuring the Pub/Sub emulator Docker container is properly launched for the test environment. - Fix for Segfault in NewInput.func2: a segmentation fault occurred when test code accessed in.metrics before it was initialized. Metrics are now explicitly initialized in the test setup to avoid nil pointer dereferencing. (cherry picked from commit 5373f23)
6 tasks
mergify Bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
Solved two issues in the GCP Pub/Sub input tests: - GCP Pub/Sub Emulator Container Missing: this has been fixed by ensuring the Pub/Sub emulator Docker container is properly launched for the test environment. - Fix for Segfault in NewInput.func2: a segmentation fault occurred when test code accessed in.metrics before it was initialized. Metrics are now explicitly initialized in the test setup to avoid nil pointer dereferencing. (cherry picked from commit 5373f23)
This was referenced Jul 4, 2025
chemamartinez
added a commit
that referenced
this pull request
Jul 4, 2025
Solved two issues in the GCP Pub/Sub input tests: - GCP Pub/Sub Emulator Container Missing: this has been fixed by ensuring the Pub/Sub emulator Docker container is properly launched for the test environment. - Fix for Segfault in NewInput.func2: a segmentation fault occurred when test code accessed in.metrics before it was initialized. Metrics are now explicitly initialized in the test setup to avoid nil pointer dereferencing. (cherry picked from commit 5373f23) Co-authored-by: Chema Martínez <chema.martinez@elastic.co>
chemamartinez
added a commit
that referenced
this pull request
Jul 4, 2025
Solved two issues in the GCP Pub/Sub input tests: - GCP Pub/Sub Emulator Container Missing: this has been fixed by ensuring the Pub/Sub emulator Docker container is properly launched for the test environment. - Fix for Segfault in NewInput.func2: a segmentation fault occurred when test code accessed in.metrics before it was initialized. Metrics are now explicitly initialized in the test setup to avoid nil pointer dereferencing. (cherry picked from commit 5373f23) Co-authored-by: Chema Martínez <chema.martinez@elastic.co>
chemamartinez
added a commit
that referenced
this pull request
Jul 7, 2025
…on tests (#45189) Solved two issues in the GCP Pub/Sub input tests: - GCP Pub/Sub Emulator Container Missing: this has been fixed by ensuring the Pub/Sub emulator Docker container is properly launched for the test environment. - Fix for Segfault in NewInput.func2: a segmentation fault occurred when test code accessed in.metrics before it was initialized. Metrics are now explicitly initialized in the test setup to avoid nil pointer dereferencing. (cherry picked from commit 5373f23) --------- Co-authored-by: Chema Martínez <chema.martinez@elastic.co>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR addresses two issues in the GCP Pub/Sub input tests:
Tests like TestTopicDoesNotExist were being skipped due to the missing PUBSUB_EMULATOR_HOST environment variable:
This has been fixed by ensuring the Pub/Sub emulator Docker container is properly launched for the test environment.
A segmentation fault occurred when test code accessed in.metrics before it was initialized.
Metrics are now explicitly initialized in the test setup to avoid nil pointer dereferencing.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run the integration tests from
x-pack/filebeatwith: