Skip to content

Conversation

@ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Jun 17, 2025

Proposed commit message

Disables sending telemetry to Microsoft when using their Go fork for producing FIPS-capable build artifacts.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None; FIPS-capable artifacts have not been released yet.

Author's Checklist

@ycombinator ycombinator requested a review from a team as a code owner June 17, 2025 12:28
@ycombinator ycombinator added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.19 Automated backport to the 8.19 branch labels Jun 17, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 17, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 17, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@ycombinator ycombinator force-pushed the fips-disable-msft-telemetry branch from a355def to 1c37c98 Compare June 17, 2025 12:30
That env var affects the behavior of the Go toolchain at build time, not the behavior of the Beats binaries at runtime.
@ycombinator ycombinator merged commit b9ce100 into elastic:main Jun 18, 2025
203 of 204 checks passed
@ycombinator ycombinator deleted the fips-disable-msft-telemetry branch June 18, 2025 14:17
mergify bot pushed a commit that referenced this pull request Jun 18, 2025
* [FIPS] Disable Microsoft Go telemetry

* Add CHANGELOG entry

* Remove check for MS_GOTOOLCHAIN_TELEMETRY_ENABLED from package.

That env var affects the behavior of the Go toolchain at build time, not the behavior of the Beats binaries at runtime.

(cherry picked from commit b9ce100)
ycombinator added a commit that referenced this pull request Jun 18, 2025
* [FIPS] Disable Microsoft Go telemetry

* Add CHANGELOG entry

* Remove check for MS_GOTOOLCHAIN_TELEMETRY_ENABLED from package.

That env var affects the behavior of the Go toolchain at build time, not the behavior of the Beats binaries at runtime.

(cherry picked from commit b9ce100)

Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants