-
Notifications
You must be signed in to change notification settings - Fork 5k
[FIPS] Disable Microsoft Go telemetry #44865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ycombinator
merged 3 commits into
elastic:main
from
ycombinator:fips-disable-msft-telemetry
Jun 18, 2025
Merged
[FIPS] Disable Microsoft Go telemetry #44865
ycombinator
merged 3 commits into
elastic:main
from
ycombinator:fips-disable-msft-telemetry
Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
a355def to
1c37c98
Compare
pierrehilbert
approved these changes
Jun 17, 2025
That env var affects the behavior of the Go toolchain at build time, not the behavior of the Beats binaries at runtime.
simitt
approved these changes
Jun 18, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
* [FIPS] Disable Microsoft Go telemetry * Add CHANGELOG entry * Remove check for MS_GOTOOLCHAIN_TELEMETRY_ENABLED from package. That env var affects the behavior of the Go toolchain at build time, not the behavior of the Beats binaries at runtime. (cherry picked from commit b9ce100)
6 tasks
ycombinator
added a commit
that referenced
this pull request
Jun 18, 2025
* [FIPS] Disable Microsoft Go telemetry * Add CHANGELOG entry * Remove check for MS_GOTOOLCHAIN_TELEMETRY_ENABLED from package. That env var affects the behavior of the Go toolchain at build time, not the behavior of the Beats binaries at runtime. (cherry picked from commit b9ce100) Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.19
Automated backport to the 8.19 branch
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Disables sending telemetry to Microsoft when using their Go fork for producing FIPS-capable build artifacts.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
None; FIPS-capable artifacts have not been released yet.
Author's Checklist