-
Notifications
You must be signed in to change notification settings - Fork 5k
[8.19](backport #41508) [Heartbeat] Adds maintenance windows !! #44689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add maint windows * Initial maint win MVP * added maintenance windows * destroy cluster * format * revert file * revert file * added lib * revert * space * add license * update * update * fix tests * lint * skip run once * Fix linting * Remove unused fields * Make update * add more test cases * utc * lint * handle errors * bit of refactor * emilio suggestion * More PR feedback * lint * add validation for map * nil condition * set count to default * add validation for only daily * add dt start validation * revrt * revrt * revert * revert * format * PR feedback * add docs * Update heartbeat/monitors/maintwin/maintwin.go Co-authored-by: Emilio Alvarez Piñeiro <[email protected]> * Update heartbeat/monitors/maintwin/maintwin.go Co-authored-by: Emilio Alvarez Piñeiro <[email protected]> * fomat * change log --------- Co-authored-by: Andrew Cholakian <[email protected]> Co-authored-by: emilioalvap <[email protected]> Co-authored-by: Emilio Alvarez Piñeiro <[email protected]> (cherry picked from commit f6fb08d) # Conflicts: # go.mod # go.sum
|
Cherry-pick of f6fb08d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
|
This pull request has not been merged yet. Could you please review and merge it @shahzad31? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @shahzad31? 🙏 |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Proposed commit message
Added maintenance windows in heartbeat in RFC 5545 format using rrule-go library, this makes it compatible with kibana alerting maintenance windows which are using the same format https://www.elastic.co/guide/en/kibana/current/maintenance-windows.html
This will allow us to simple pass values from alerting maintenance windows where those are applicable to synthetics monitors as heartbeat configs
example being
heartbeat.monitors:
Limitations
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #41508 done by [Mergify](https://mergify.com).