Skip to content

[Flaky test] Disable flaky zookeeper tests #43381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
faec merged 3 commits into from
Mar 24, 2025
Merged

[Flaky test] Disable flaky zookeeper tests #43381

faec merged 3 commits into from
Mar 24, 2025

Conversation

@faec
Copy link
Contributor

@faec faec commented Mar 20, 2025 •
edited
Loading

Disable the flaky test metricbeat/module/zookeeper/test_zookeeper, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 20, 2025
@mergify mergify bot assigned faec Mar 20, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @faec? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@faec faec added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 20, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 20, 2025
@faec faec added Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team flaky-test Unstable or unreliable test cases. backport-active-all Automated backport with mergify to all the active branches labels Mar 20, 2025
@faec faec marked this pull request as ready for review March 20, 2025 17:24
@faec faec requested a review from a team as a code owner March 20, 2025 17:24
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 20, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@faec
Copy link
Contributor Author

faec commented Mar 20, 2025

cc @lalit-satapathy

@faec faec changed the title [CI troubleshooting] Add details when zookeeper test fails [Flaky test] Disable flaky zookeeper tests Mar 20, 2025
ishleenk17
ishleenk17 approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@faec faec merged commit 9e29bcb into elastic:main Mar 24, 2025
33 checks passed
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
@faec @mergify
[Flaky test] Disable flaky zookeeper tests (#43381)
48a764c 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)
@mergify mergify bot mentioned this pull request Mar 24, 2025
Merged
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
@faec @mergify
[Flaky test] Disable flaky zookeeper tests (#43381)
26b5ee6 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)
@mergify mergify bot mentioned this pull request Mar 24, 2025
Merged
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
@faec @mergify
[Flaky test] Disable flaky zookeeper tests (#43381)
02ab00b 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)
@mergify mergify bot mentioned this pull request Mar 24, 2025
Merged
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
@faec @mergify
[Flaky test] Disable flaky zookeeper tests (#43381)
76ca967 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)
@mergify mergify bot mentioned this pull request Mar 24, 2025
Merged
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
@faec @mergify
[Flaky test] Disable flaky zookeeper tests (#43381)
c403afa 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)
@mergify mergify bot mentioned this pull request Mar 24, 2025
Merged
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
@faec @mergify
[Flaky test] Disable flaky zookeeper tests (#43381)
50c4695 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)
@mergify mergify bot mentioned this pull request Mar 24, 2025
Merged
@faec faec deleted the zookeeper-test-debug branch March 24, 2025 13:54
faec added a commit that referenced this pull request Mar 24, 2025
@mergify @faec
[Flaky test] Disable flaky zookeeper tests (#43381) (#43444)
e7820ca 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)

Co-authored-by: Fae Charlton <[email protected]>
faec added a commit that referenced this pull request Mar 24, 2025
@mergify @faec
[Flaky test] Disable flaky zookeeper tests (#43381) (#43445)
7b5ed67 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)

Co-authored-by: Fae Charlton <[email protected]>
faec added a commit that referenced this pull request Mar 24, 2025
@mergify @faec
[Flaky test] Disable flaky zookeeper tests (#43381) (#43448)
19b52f2 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)

Co-authored-by: Fae Charlton <[email protected]>
faec added a commit that referenced this pull request Mar 24, 2025
@mergify @faec
[Flaky test] Disable flaky zookeeper tests (#43381) (#43446)
632b391 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)

Co-authored-by: Fae Charlton <[email protected]>
faec added a commit that referenced this pull request Mar 24, 2025
@mergify @faec
[Flaky test] Disable flaky zookeeper tests (#43381) (#43447)
615789c 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)

Co-authored-by: Fae Charlton <[email protected]>
faec added a commit that referenced this pull request Apr 17, 2025
@mergify @faec
[Flaky test] Disable flaky zookeeper tests (#43381) (#43443)
c2489f6 
Disable the flaky test `metricbeat/module/zookeeper/test_zookeeper`, reported in #43385.

Also add a message to the failing assertions indicating the actual data the tests failed on, so when a failure does happen we can see what caused it.

(cherry picked from commit 9e29bcb)

Co-authored-by: Fae Charlton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@shmsr shmsr shmsr approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

@faec faec

Labels

backport-active-all Automated backport with mergify to all the active branches flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@faec @elasticmachine @pierrehilbert @shmsr @ishleenk17