[8.x](backport #43322) Allow faccessat(2) as well as faccessat2(2) #43374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an older faccessat(2) that is used by older glibc, particularly the one in ubuntu 20.04. Any cgo program (like any processor using quark) might end up needing that. (cherry picked from commit 73353a8)
mergify
bot
requested review from
belimawr and
rdner
and removed request for
a team
botelastic
bot
added
the
needs_team
github-actions
bot
added
bug
Team:Elastic-Agent-Data-Plane
Contributor
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
belimawr
approved these changes
Mar 20, 2025
pierrehilbert
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
There's an older faccessat(2) that is used by older glibc, particularly the one in ubuntu 20.04.
Any cgo program (like any processor using quark) might end up needing that.
Checklist
Add a checklist of things that are required to be reviewed in order to have the PR approved
List here all the items you have verified BEFORE sending this PR. Please DO NOT remove any item, striking through those that do not apply. (Just in case, strikethrough uses two tildes.
Scratch this.)[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Related to an internal issue raised.
Use cases
when using
kernel_tracingas the backendadd_session_metadata_processoror the newsystem/processmodule backend, it ends up calling faccessat(3) which might be faccessat2(2) or faccessat(2), depending on the glibc version.Allow both otherwise
kernel_tracingwill always fail.This is an automatic backport of pull request #43322 done by Mergify.