Skip to content

[Flaky test] Disable flaky metricbeat process test #43342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
faec merged 1 commit into from
Mar 18, 2025
Merged

[Flaky test] Disable flaky metricbeat process test #43342

faec merged 1 commit into from
Mar 18, 2025

Conversation

@faec
Copy link
Contributor

@faec faec commented Mar 18, 2025

Disable metricbeat/module/system/process TestFetchDegradeOnPartial reported in #42809.

Also change the failing t.Assert to t.Require so that when it does fail, it doesn't fall through to a panic on the next line by accessing the first element of an empty array.

@faec faec added flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Mar 18, 2025
@faec faec self-assigned this Mar 18, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 18, 2025
@faec faec marked this pull request as ready for review March 18, 2025 17:45
@faec faec requested a review from a team as a code owner March 18, 2025 17:45
@faec faec requested review from belimawr and rdner March 18, 2025 17:45
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 18, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @faec? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@faec faec added the backport-active-all Automated backport with mergify to all the active branches label Mar 18, 2025
@faec faec merged commit 0b2e66a into elastic:main Mar 18, 2025
34 checks passed
@faec faec deleted the disable-flaky-process-test branch March 18, 2025 19:14
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@faec @mergify
disable flaky metricbeat process test (#43342)
b81d18f 
Disable `metricbeat/module/system/process TestFetchDegradeOnPartial` reported in #42809.

Also change the failing `t.Assert` to `t.Require` so that when it does fail, it doesn't fall through to a panic on the next line by accessing the first element of an empty array.

(cherry picked from commit 0b2e66a)
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@faec @mergify
disable flaky metricbeat process test (#43342)
6e591fd 
Disable `metricbeat/module/system/process TestFetchDegradeOnPartial` reported in #42809.

Also change the failing `t.Assert` to `t.Require` so that when it does fail, it doesn't fall through to a panic on the next line by accessing the first element of an empty array.

(cherry picked from commit 0b2e66a)
This was referenced Mar 18, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@faec @mergify
disable flaky metricbeat process test (#43342)
67062cd 
Disable `metricbeat/module/system/process TestFetchDegradeOnPartial` reported in #42809.

Also change the failing `t.Assert` to `t.Require` so that when it does fail, it doesn't fall through to a panic on the next line by accessing the first element of an empty array.

(cherry picked from commit 0b2e66a)

# Conflicts:
#	metricbeat/module/system/process/process_test.go
@mergify mergify bot mentioned this pull request Mar 18, 2025
Closed
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@faec @mergify
disable flaky metricbeat process test (#43342)
f1e50f6 
Disable `metricbeat/module/system/process TestFetchDegradeOnPartial` reported in #42809.

Also change the failing `t.Assert` to `t.Require` so that when it does fail, it doesn't fall through to a panic on the next line by accessing the first element of an empty array.

(cherry picked from commit 0b2e66a)

# Conflicts:
#	metricbeat/module/system/process/process_test.go
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@faec @mergify
disable flaky metricbeat process test (#43342)
2d7d3d1 
Disable `metricbeat/module/system/process TestFetchDegradeOnPartial` reported in #42809.

Also change the failing `t.Assert` to `t.Require` so that when it does fail, it doesn't fall through to a panic on the next line by accessing the first element of an empty array.

(cherry picked from commit 0b2e66a)
This was referenced Mar 18, 2025
Closed
Merged
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@faec @mergify
disable flaky metricbeat process test (#43342)
a4495eb 
Disable `metricbeat/module/system/process TestFetchDegradeOnPartial` reported in #42809.

Also change the failing `t.Assert` to `t.Require` so that when it does fail, it doesn't fall through to a panic on the next line by accessing the first element of an empty array.

(cherry picked from commit 0b2e66a)

# Conflicts:
#	metricbeat/module/system/process/process_test.go
@mergify mergify bot mentioned this pull request Mar 18, 2025
Closed
faec added a commit that referenced this pull request Mar 18, 2025
@mergify @faec
disable flaky metricbeat process test (#43342) (#43345)
186669a 
Disable `metricbeat/module/system/process TestFetchDegradeOnPartial` reported in #42809.

Also change the failing `t.Assert` to `t.Require` so that when it does fail, it doesn't fall through to a panic on the next line by accessing the first element of an empty array.

(cherry picked from commit 0b2e66a)

Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
faec added a commit that referenced this pull request Mar 18, 2025
@mergify @faec
disable flaky metricbeat process test (#43342) (#43346)
51091b1 
Disable `metricbeat/module/system/process TestFetchDegradeOnPartial` reported in #42809.

Also change the failing `t.Assert` to `t.Require` so that when it does fail, it doesn't fall through to a panic on the next line by accessing the first element of an empty array.

(cherry picked from commit 0b2e66a)

Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
faec added a commit that referenced this pull request Mar 18, 2025
@mergify @faec
disable flaky metricbeat process test (#43342) (#43349)
0b59f91 
Disable `metricbeat/module/system/process TestFetchDegradeOnPartial` reported in #42809.

Also change the failing `t.Assert` to `t.Require` so that when it does fail, it doesn't fall through to a panic on the next line by accessing the first element of an empty array.

(cherry picked from commit 0b2e66a)

Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@faec faec

Labels

backport-active-all Automated backport with mergify to all the active branches flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@faec @elasticmachine @pierrehilbert