Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 18, 2025

Proposed commit message

do not overwrite mage version in makefile and use go.mod as the source of truth.

this was causing CI job to always redownload a different mage version even if the go cache was present

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

make mage

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #43287 done by [Mergify](https://mergify.com).

* refactor: use go.mod mage version

do not overwrite mage version in makefile and use go.mod as the
source of truth

* Update mage-install.mk

* Update mage-install.mk

(cherry picked from commit 13f7cab)
@mergify mergify bot requested a review from a team as a code owner March 18, 2025 13:16
@mergify mergify bot added the backport label Mar 18, 2025
@mergify mergify bot requested review from VihasMakwana and khushijain21 and removed request for a team March 18, 2025 13:16
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2025
@github-actions github-actions bot added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 18, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2025
@kruskall kruskall enabled auto-merge (squash) March 18, 2025 14:01
@kruskall kruskall merged commit b898909 into 8.x Mar 18, 2025
146 checks passed
@kruskall kruskall deleted the mergify/bp/8.x/pr-43287 branch March 18, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants