Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 18, 2025

Proposed commit message

Added a warn log message to all of vSphere metric sets to warn if vSphere connection has been configured as insecure

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Example of log entry

{"log.level":"warn","@timestamp":"2025-03-07T11:58:09.323+0200","log.logger":"vsphere.cluster","log.origin":{"function":"github.com/elastic/beats/v7/metricbeat/module/vsphere/security.WarnIfInsecure","file.name":"security/logging.go","file.line":7},"message":"Your vSphere connection is configured as insecure. This can lead to man in the middle attack.","service.name":"metricbeat","metricset":"cluster","ecs.version":"1.6.0"}

This is an automatic backport of pull request #43104 done by [Mergify](https://mergify.com).

…gured as insecure (#43104)

* feat: add warning log message to indicate vSphere connection is configured as insecure

* chore: add CHANGELOG.asciidoc entry

* move changelog entry from CHANGELOG.asciidoc to CHANGELOG.next.asciidoc

* add missing license header

* fix linter issue

* fix changelog entry section

* Update metricbeat/module/vsphere/security/logging.go

Co-authored-by: Ishleen Kaur <[email protected]>

---------

Co-authored-by: Ishleen Kaur <[email protected]>
(cherry picked from commit 4c7d45c)
@mergify mergify bot added the backport label Mar 18, 2025
@mergify mergify bot requested a review from a team as a code owner March 18, 2025 12:30
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2025
@github-actions github-actions bot added enhancement Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Mar 18, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2025
@stefans-elastic stefans-elastic merged commit b582615 into 8.x Mar 21, 2025
33 checks passed
@stefans-elastic stefans-elastic deleted the mergify/bp/8.x/pr-43104 branch March 21, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport enhancement Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants