-
Notifications
You must be signed in to change notification settings - Fork 5k
[8.17](backport #43106) "(chore) Update elastic-agent-lib to v0.18.9" #43146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* [otelconsumer]: Add support for conversion of type any * fix lint * poc * first draft * make update * remove files from previous commit * make docs * add changelgo * update docs * make update * remove it from public facing config * remove changelog * update notice * add test * fix test * (chore) Update elastic-agent-lib to v0.18.9 * remove old files * remove * remove (cherry picked from commit 198197d) # Conflicts: # NOTICE.txt # go.mod # go.sum
|
Cherry-pick of 198197d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Hmmm I thought the CI was failing due to flaky tests, but it seems that 8.17 and 8.16 backports are broken due to the libs bump. https://buildkite.com/elastic/filebeat/builds/14865#01958fd4-32e6-4710-996d-cfcf2875f38e It complains about two mapstr.M sharing the same backing map, which shouldn't happen. This is likely a guard to ensure I recall seeing similar failures before, but it was fixed in elastic/elastic-agent-libs#283 for v0.18.7. We require v0.18.9 here so this shouldn't happen. It is also weird that all the other backports are not failing on these tests. I'll keep digging. |
|
This pull request has not been merged yet. Could you please review and merge it @khushijain21? 🙏 |
|
I found out why the tests broke with this PR, turns out it is not related to libs but to testify/assert. The bump to v1.10.0 includes a fix for |
Proposed commit message
Update
elastic-agent-libversionThis is an automatic backport of pull request #43106 done by [Mergify](https://mergify.com).