filebeat,libbeat,x-pack/filebeat: clean up state store types #43063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
Filebeat
botelastic
bot
added
needs_team
efd6
force-pushed
the
st7819-statestore_gardening
branch
3 times, most recently
from
cf6742d to
ce38f10
Compare
Contributor
Author
|
/test |
efd6
force-pushed
the
st7819-statestore_gardening
branch
from
ce38f10 to
0d96623
Compare
Contributor
Author
|
/test |
efd6
force-pushed
the
st7819-statestore_gardening
branch
2 times, most recently
from
2633073 to
403b3ad
Compare
This centralises the state store to simplify and clarify the use of persistent stores.
efd6
force-pushed
the
st7819-statestore_gardening
branch
from
403b3ad to
a09c2b9
Compare
Contributor
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
leehinman
reviewed
Mar 17, 2025
Contributor
leehinman
left a comment
leehinman
left a comment
There was a problem hiding this comment.
LGTM except for the linter.
Contributor
Author
|
@leehinman All the linter errors are due to incorrect use of the linter and how that breaks it. None can be fixed in this PR. Issue #39589 |
leehinman
approved these changes
Mar 17, 2025
efd6
added
Team:obs-ds-hosted-services
Contributor
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
Contributor
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
andrewkroh
approved these changes
Mar 18, 2025
filebeat/beater/store.go
Outdated
|
|
||
| // Access returns the storage registry depending on the type. Default is the file store. | ||
| func (s *filebeatStore) Access(typ string) (*statestore.Store, error) { | ||
| // AccessType returns the storage registry depending on the type. Default is the file store. |
Kavindu-Dodan
approved these changes
Mar 19, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
This centralises the state store to simplify and clarify the use of persistent stores. (cherry picked from commit df62e10) # Conflicts: # filebeat/beater/filebeat.go # filebeat/input/journald/environment_test.go
mergify bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
This centralises the state store to simplify and clarify the use of persistent stores. (cherry picked from commit df62e10)
This was referenced Mar 19, 2025
efd6
added a commit
that referenced
this pull request
Mar 19, 2025
…#43365) This centralises the state store to simplify and clarify the use of persistent stores. (cherry picked from commit df62e10) Co-authored-by: Dan Kortschak <[email protected]>
efd6
added a commit
that referenced
this pull request
Mar 19, 2025
…te store types (#43366) * filebeat,libbeat,x-pack/filebeat: clean up state store types (#43063) This centralises the state store to simplify and clarify the use of persistent stores. (cherry picked from commit df62e10) # Conflicts: # filebeat/beater/filebeat.go # filebeat/input/journald/environment_test.go * fix conflicts --------- Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs