feat(fips): do not allow scram sasl mechanism in fips mode #43062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scram is using custom implementation of pbkdf2 which is not allowed in fips mode
botelastic
bot
added
the
needs_team
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
kruskall
added
backport-8.x
simitt
approved these changes
Mar 6, 2025
Contributor
|
@kruskall how did you detect this issue? Any tooling that you used for it given that it is not stdlib implementation? |
Member
Author
|
nope, just spotted the dependency since it was linked in the final binary |
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
mauri870
approved these changes
Mar 11, 2025
Member
mauri870
left a comment
mauri870
left a comment
There was a problem hiding this comment.
Code-wise, it looks fine, but I'm not experienced with SASL and Kafka to provide a meaningful review. The history of this file is quite shallow, so I can't find any previous developers to ping.
mergify bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
* feat(fips): do not allow scram sasl mechanism in fips mode scram is using custom implementation of pbkdf2 which is not allowed in fips mode * Update sasl_fips.go * Update sasl_fips.go (cherry picked from commit 9761c36)
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
* feat(fips): do not allow scram sasl mechanism in fips mode scram is using custom implementation of pbkdf2 which is not allowed in fips mode * Update sasl_fips.go * Update sasl_fips.go (cherry picked from commit 9761c36)
6 tasks
kruskall
added a commit
that referenced
this pull request
Mar 14, 2025
…43204) * feat(fips): do not allow scram sasl mechanism in fips mode scram is using custom implementation of pbkdf2 which is not allowed in fips mode * Update sasl_fips.go * Update sasl_fips.go (cherry picked from commit 9761c36) Co-authored-by: kruskall <[email protected]>
kruskall
added a commit
that referenced
this pull request
Mar 14, 2025
…43203) * feat(fips): do not allow scram sasl mechanism in fips mode scram is using custom implementation of pbkdf2 which is not allowed in fips mode * Update sasl_fips.go * Update sasl_fips.go (cherry picked from commit 9761c36) Co-authored-by: kruskall <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
scram is using custom implementation of pbkdf2 which is not allowed in fips mode
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs