(cleanup) Remove the unused libbeat/common/op package #43058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faec
added
cleanup
Team:Elastic-Agent-Data-Plane
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
jlind23
previously approved these changes
Mar 6, 2025
Contributor
|
Buildkite test it |
Contributor
|
buildkite test this |
Member
|
LGTM, will approve once CI is green. |
AndersonQ
approved these changes
Mar 11, 2025
Member
AndersonQ
left a comment
AndersonQ
left a comment
There was a problem hiding this comment.
thanks, CI passing, it's good to go
mauri870
approved these changes
Mar 12, 2025
VihasMakwana
approved these changes
Mar 13, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
The `libbeat/common/op` package has logic errors, and no remaining callers. (cherry picked from commit 97f372b)
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
The `libbeat/common/op` package has logic errors, and no remaining callers. (cherry picked from commit 97f372b)
6 tasks
rdner
pushed a commit
that referenced
this pull request
Mar 19, 2025
The `libbeat/common/op` package has logic errors, and no remaining callers. (cherry picked from commit 97f372b) Co-authored-by: Fae Charlton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
libbeat/common/oppackage has logic errors, and no remaining callers.Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.