[8.x](backport #42402) FIPS Build #43051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
AndersonQ and
khushijain21
and removed request for
a team
botelastic
bot
added
the
needs_team
github-actions
bot
added
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
Contributor
|
8.x is still on go v1.22.x |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏 |
Member
|
I think the CI failures might be some flakiness. I'd suggest to update the branch and retry |
AndersonQ
approved these changes
Mar 12, 2025
Member
AndersonQ
left a comment
AndersonQ
left a comment
There was a problem hiding this comment.
As long as CI passes, it's good to go
Enable FIPS compliant builds when the env var FIPS=true is set. Artifacts are built with the microsfot/go toolchain with the env var GOEXPERIMENT=systemcrypto and the build tag "-tags=requirefips". In order to run the resulting binary, the system must have a FIPS compliant crypto provider. (cherry picked from commit 83e0ec0)
pchila
force-pushed
the
mergify/bp/8.x/pr-42402
branch
from
c891ac6 to
3291bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Enable FIPS compliant builds when the env var
FIPS=trueis set.Artifacts are built with the microsfot/go toolchain with the env var
GOEXPERIMENT=systemcryptoand the build tag"-tags=requirefips".In order to run the resulting binary, the system must have a FIPS compliant crypto provider.
Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
None
How to test this PR locally
TODO
This is an automatic backport of pull request #42402 done by Mergify.