Skip to content

TEST: bump go version to 1.23#42960

Closed
v1v wants to merge 17 commits into
elastic:mainfrom
v1v:test/42705
Closed

TEST: bump go version to 1.23#42960
v1v wants to merge 17 commits into
elastic:mainfrom
v1v:test/42705

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Feb 28, 2025

Use elastic/golang-crossbuild#527 on the top of #42705

Remove the qemu dependency - use the host architecture always
Use the specific golang crossbuild image for arm64 in arm64
Use the private docker namespace to validate things work ok

@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 28, 2025
@botelastic
Copy link
Copy Markdown

botelastic Bot commented Feb 28, 2025

This pull request doesn't have a Team:<team> label.

@v1v v1v changed the title feat: bump go version to 1.23 TEST: bump go version to 1.23 Feb 28, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 28, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @v1v? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@mergify mergify Bot assigned v1v Feb 28, 2025
- label: ":ubuntu: x-pack/dockerlogbeat: Ubuntu x86_64 Unit Tests"
key: "mandatory-linux-unit-test"
command: |
source .buildkite/scripts/qemu.sh
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unitTest uses the golang-crossbuild hence we need to use qemu

key: "mandatory-cross-compile"
command: "make -C metricbeat crosscompile"
command: |
source .buildkite/scripts/qemu.sh
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crosscompile uses the golang-crossbuild hence we need to use qemu

Comment on lines -44 to +46
beatsFPMImage = "docker.elastic.co/beats-dev/fpm"
beatsFPMImage = "docker.elastic.co/observability-ci/fpm"
// BeatsCrossBuildImage is the image used for crossbuilding Beats.
BeatsCrossBuildImage = "docker.elastic.co/beats-dev/golang-crossbuild"
BeatsCrossBuildImage = "docker.elastic.co/observability-ci/golang-crossbuild"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be needed as soon as we merge elastic/golang-crossbuild#527

@@ -0,0 +1,19 @@
#!/usr/bin/env bash
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specific script that can be used in other places

@v1v v1v mentioned this pull request Feb 28, 2025
6 tasks
@v1v v1v closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants