-
Notifications
You must be signed in to change notification settings - Fork 5k
chore: add missing changelog entry about a fix from elastic-agent-libs #42804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Test failures are related to a breaking change in libs. |
2ccca1f to
b9fabb1
Compare
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
@mauri870 I have merged a change to agent-libs for improved warning logging during SSL handling that I would love backported as well, would you be open to carving a version that includes elastic/elastic-agent-libs#285 (already merged) and bumping to that version in this PR? So that we avoid doing bumping + backports twice for the lib update |
changelog/fragments/1740772872-mitigate-symlink-following-when-rotating-files.yaml
Outdated
Show resolved
Hide resolved
|
/test |
|
Thanks, will approve once CI is passing. |
I finally got a green CI! Just waiting on your approval. Thanks! |
|
Unfortunately, another PR first bumped the libs to v0.18.9 at #43106. The diff now only shows the changelog entry. I think we can merge it as is, and for the backports, I will ensure we have the up-to-date version of the library. |
Moved the changelog to the right place.
rdner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message should have a reference to the actual library bump and clearly described as a follow up.
I think it's good to have this changelog entry.
* chore: update elastic-agent-libs * add changelog * fix changelog entry (cherry picked from commit d1450fa)
* chore: update elastic-agent-libs * add changelog * fix changelog entry (cherry picked from commit d1450fa)
* chore: update elastic-agent-libs * add changelog * fix changelog entry (cherry picked from commit d1450fa)
* chore: update elastic-agent-libs * add changelog * fix changelog entry (cherry picked from commit d1450fa)
* chore: update elastic-agent-libs * add changelog * fix changelog entry (cherry picked from commit d1450fa)
… from elastic-agent-libs (#43141) * chore: update elastic-agent-libs to v0.18.8 (#42804) * chore: update elastic-agent-libs * add changelog * fix changelog entry (cherry picked from commit d1450fa) * update changelog --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
… from elastic-agent-libs (#43140) * chore: update elastic-agent-libs to v0.18.8 (#42804) * chore: update elastic-agent-libs * add changelog * fix changelog entry (cherry picked from commit d1450fa) * fix changelog --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
…x from elastic-agent-libs (#43142) * chore: update elastic-agent-libs to v0.18.8 (#42804) * chore: update elastic-agent-libs * add changelog * fix changelog entry (cherry picked from commit d1450fa) * tidy changelog --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
…x from elastic-agent-libs (#43143) * chore: update elastic-agent-libs to v0.18.8 (#42804) * chore: update elastic-agent-libs * add changelog * fix changelog entry (cherry picked from commit d1450fa) * tidy changelog --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
…x from elastic-agent-libs (#43144) * chore: update elastic-agent-libs to v0.18.8 (#42804) * chore: update elastic-agent-libs * add changelog * fix changelog entry (cherry picked from commit d1450fa) * tidy changelog --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Proposed commit message
Elastic Agent libs v0.18.7 included a fix to rotate a file when the destination is a symbolic link. This PR adds a changelog entry for the fix.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.