-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.18](backport #42626) Fixing NPCAP install with agentbeat #42731
Conversation
* test * run system tests for agentbeat * run system tests for agentbeat * test * Update pipeline.xpack.agentbeat.yml * reorder * try 11 * running from pb context * running from pb context * running from pb context * config file * config file * test without any * test updating for os specific config * force windows * filesystem does not save files, urgh * try copy in test binary * more info to output * use abs * pass wd to npcap getter * fmt * revert conf dir * packaging * Update packetbeat.yml * Revert "revert conf dir" This reverts commit 062cad9. * packaging (cherry picked from commit 6763697) # Conflicts: # x-pack/packetbeat/magefile.go # x-pack/packetbeat/tests/system/app_run_agentbeat_test.go
Cherry-pick of 6763697 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
- label: ":windows: x-pack/agentbeat: Win 2022 System Tests" | ||
key: "mandatory-win-2022-system-tests" | ||
command: | | ||
# .buildkite/scripts/gcp_auth.ps1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michalpristas is this commented out on purpose?
I see the following failure which might be related: https://buildkite.com/elastic/beats-xpack-agentbeat/builds/7836#0195137e-6ead-45f3-8641-1919a716408b/122-130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this file is not here, i need to do some other backports and uncomment this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backports done, uncommented
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, provided that CI becomes green
For this to test properly we need snapshot build (find snapshot for windows in buildkite pipeline artifacts for agentbeat packaging)
For some reason locally built agentbeats do not have an issue.
How to test
spin up Window Server 2022 VM without npcap
use config packetbeat.yml
run
agentbeat packetbeat run -c packetbeat.yml
no error should be present
Closes elastic/elastic-agent#6108
This is an automatic backport of pull request #42626 done by Mergify.