feat(fips): disable usage of flowhash/communityid in fips mode #42582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 1 of the ID, the hash algorithm is SHA1 usage of flowhash fails with the following message when the stdlib is in fips only mode: crypto/sha1: use of SHA-1 is not allowed in FIPS 140-only mode
botelastic
bot
added
the
needs_team
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
jlind23
added
the
Team:Elastic-Agent-Data-Plane
botelastic
bot
removed
the
needs_team
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
jlind23
added
needs_team
botelastic
bot
removed
the
needs_team
|
This pull request doesn't have a |
faec
approved these changes
Feb 10, 2025
simitt
reviewed
Feb 17, 2025
mauri870
approved these changes
Feb 26, 2025
simitt
approved these changes
Mar 5, 2025
Contributor
|
@nfritts could we have someone to review here? |
nfritts
approved these changes
Mar 18, 2025
taylor-swanson
approved these changes
Mar 18, 2025
mjwolf
approved these changes
Mar 18, 2025
Contributor
|
@kruskall We are now good to go |
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
* feat(fips): disable usage of flowhash/communityid in fips mode In version 1 of the ID, the hash algorithm is SHA1 usage of flowhash fails with the following message when the stdlib is in fips only mode: crypto/sha1: use of SHA-1 is not allowed in FIPS 140-only mode * test: skip communityid tests in fips mode * test: skip communityid tests in fips mode * fix: resolve compile errors * lint: fix linter issues * refactor: add fips noop community implementation * lint: fix linter issues (cherry picked from commit 3b00fcb)
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
* feat(fips): disable usage of flowhash/communityid in fips mode In version 1 of the ID, the hash algorithm is SHA1 usage of flowhash fails with the following message when the stdlib is in fips only mode: crypto/sha1: use of SHA-1 is not allowed in FIPS 140-only mode * test: skip communityid tests in fips mode * test: skip communityid tests in fips mode * fix: resolve compile errors * lint: fix linter issues * refactor: add fips noop community implementation * lint: fix linter issues (cherry picked from commit 3b00fcb)
6 tasks
kruskall
added a commit
that referenced
this pull request
Mar 18, 2025
… (#43354) * feat(fips): disable usage of flowhash/communityid in fips mode In version 1 of the ID, the hash algorithm is SHA1 usage of flowhash fails with the following message when the stdlib is in fips only mode: crypto/sha1: use of SHA-1 is not allowed in FIPS 140-only mode * test: skip communityid tests in fips mode * test: skip communityid tests in fips mode * fix: resolve compile errors * lint: fix linter issues * refactor: add fips noop community implementation * lint: fix linter issues (cherry picked from commit 3b00fcb) Co-authored-by: kruskall <[email protected]>
kruskall
added a commit
that referenced
this pull request
Mar 18, 2025
… (#43353) * feat(fips): disable usage of flowhash/communityid in fips mode In version 1 of the ID, the hash algorithm is SHA1 usage of flowhash fails with the following message when the stdlib is in fips only mode: crypto/sha1: use of SHA-1 is not allowed in FIPS 140-only mode * test: skip communityid tests in fips mode * test: skip communityid tests in fips mode * fix: resolve compile errors * lint: fix linter issues * refactor: add fips noop community implementation * lint: fix linter issues (cherry picked from commit 3b00fcb) Co-authored-by: kruskall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
In version 1 of the ID, the hash algorithm is SHA1
usage of flowhash fails with the following message when the stdlib is in fips only mode:
crypto/sha1: use of SHA-1 is not allowed in FIPS 140-only modePR hides the communityid usage behind a method which returns an empty string in fips mode, to avoid any potential misuse and better encapsulation.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs