Add latency metrics for logstash async output #42565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
strawgate
added
Team:Elastic-Agent-Data-Plane
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
5 tasks
AndersonQ
approved these changes
Feb 4, 2025
Member
AndersonQ
left a comment
AndersonQ
left a comment
There was a problem hiding this comment.
Would it be feasible to add some tests? The other PR also does not have a y tests, so I'll approve it.
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Add latency metrics for logstash async output * Properly handle per-batch latency (cherry picked from commit accc5e1)
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Add latency metrics for logstash async output * Properly handle per-batch latency (cherry picked from commit accc5e1) # Conflicts: # libbeat/outputs/logstash/async.go
This was referenced Feb 4, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Add latency metrics for logstash async output * Properly handle per-batch latency (cherry picked from commit accc5e1)
mergify bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Add latency metrics for logstash async output * Properly handle per-batch latency (cherry picked from commit accc5e1)
strawgate
added a commit
that referenced
this pull request
Feb 4, 2025
* Add latency metrics for logstash async output * Properly handle per-batch latency (cherry picked from commit accc5e1) Co-authored-by: William Easton <[email protected]>
5 tasks
rdner
added a commit
that referenced
this pull request
Feb 5, 2025
* Add latency metrics for logstash async output * Properly handle per-batch latency (cherry picked from commit accc5e1) Co-authored-by: William Easton <[email protected]> Co-authored-by: Denis <[email protected]>
5 tasks
strawgate
added a commit
that referenced
this pull request
Feb 19, 2025
* Add latency metrics for logstash async output * Properly handle per-batch latency (cherry picked from commit accc5e1) Co-authored-by: William Easton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #42537 but for Logstash
#37445 added latency metrics for the sync output but the async output is what's used by the default configuration