Skip to content

Write latency statistics go under a histogram key #42514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jlind23 merged 4 commits into from
Jan 31, 2025
Merged

Write latency statistics go under a histogram key #42514

jlind23 merged 4 commits into from
Jan 31, 2025

Conversation

@strawgate
Copy link
Contributor

@strawgate strawgate commented Jan 30, 2025 •
edited by dliappis
Loading

follow-on from #42439

  1. write latency goes under a histogram key
  2. Fix broken metricbeat Integration tests caused by Include full queue metrics in the monitoring index #42439

Closes #42520

@strawgate strawgate requested a review from a team as a code owner January 30, 2025 21:49
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 30, 2025
@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @strawgate? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 30, 2025
@strawgate strawgate mentioned this pull request Jan 30, 2025
Merged
6 tasks
@strawgate strawgate enabled auto-merge (squash) January 31, 2025 01:03
@jlind23 jlind23 added backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch labels Jan 31, 2025
@jlind23 jlind23 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jan 31, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 31, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 31, 2025
@jlind23 jlind23 disabled auto-merge January 31, 2025 07:59
@jlind23 jlind23 merged commit 0ff52eb into main Jan 31, 2025
11 of 32 checks passed
@jlind23 jlind23 deleted the fix-write-latency branch January 31, 2025 07:59
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@strawgate @mergify
Write latency statistics go under a histogram key (#42514)
9eb62df 
* Write latency goes under histogram

* Update fields.yml to include new exposed beats stats

* Add't updates for integ tests

---------

Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0ff52eb)

# Conflicts:
#	metricbeat/module/beat/stats/data.go
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@strawgate @mergify
Write latency statistics go under a histogram key (#42514)
6a51863 
* Write latency goes under histogram

* Update fields.yml to include new exposed beats stats

* Add't updates for integ tests

---------

Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0ff52eb)

# Conflicts:
#	metricbeat/module/beat/stats/data.go
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
@jlind23 jlind23 added the backport-9.0 Automated backport to the 9.0 branch label Jan 31, 2025
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@strawgate @mergify
Write latency statistics go under a histogram key (#42514)
b00f114 
* Write latency goes under histogram

* Update fields.yml to include new exposed beats stats

* Add't updates for integ tests

---------

Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0ff52eb)

# Conflicts:
#	metricbeat/module/beat/stats/data.go
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
mergify bot pushed a commit that referenced this pull request Jan 31, 2025
@strawgate @jlind23 @mergify
Write latency statistics go under a histogram key (#42514)
13b8e55 
* Write latency goes under histogram

* Update fields.yml to include new exposed beats stats

* Add't updates for integ tests

---------

Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0ff52eb)
@mergify mergify bot mentioned this pull request Jan 31, 2025
Merged
strawgate added a commit that referenced this pull request Jan 31, 2025
@mergify @strawgate
[8.x](backport #42514) Write latency statistics go under a histogram …
57aeae6 
…key (#42527)

* Write latency statistics go under a histogram key (#42514)

* Write latency goes under histogram

* Update fields.yml to include new exposed beats stats

* Add't updates for integ tests

---------

Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0ff52eb)

# Conflicts:
#	metricbeat/module/beat/stats/data.go

* Remove git merge markers

---------

Co-authored-by: William Easton <[email protected]>
@strawgate strawgate mentioned this pull request Jan 31, 2025
Closed
5 tasks
strawgate added a commit that referenced this pull request Jan 31, 2025
@mergify @strawgate
[8.17](backport #42514) Write latency statistics go under a histogram…
91c0bfd 
… key (#42528)

* Write latency statistics go under a histogram key (#42514)

* Write latency goes under histogram

* Update fields.yml to include new exposed beats stats

* Add't updates for integ tests

---------

Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0ff52eb)

# Conflicts:
#	metricbeat/module/beat/stats/data.go

* Remove git merge markers

---------

Co-authored-by: William Easton <[email protected]>
strawgate added a commit that referenced this pull request Jan 31, 2025
@mergify @strawgate
[8.18](backport #42514) Write latency statistics go under a histogram…
9550d0d 
… key (#42529)

* Write latency statistics go under a histogram key (#42514)

* Write latency goes under histogram

* Update fields.yml to include new exposed beats stats

* Add't updates for integ tests

---------

Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0ff52eb)

# Conflicts:
#	metricbeat/module/beat/stats/data.go

* Remove git merge markers

---------

Co-authored-by: William Easton <[email protected]>
strawgate added a commit that referenced this pull request Feb 4, 2025
@mergify @strawgate
Write latency statistics go under a histogram key (#42514) (#42530)
5c4f205 
* Write latency goes under histogram

* Update fields.yml to include new exposed beats stats

* Add't updates for integ tests

---------

Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0ff52eb)

Co-authored-by: William Easton <[email protected]>
@strawgate strawgate mentioned this pull request Feb 4, 2025
Closed
5 tasks
@strawgate strawgate mentioned this pull request Feb 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlind23 jlind23 jlind23 approved these changes

+1 more reviewer

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@strawgate strawgate

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Metricbeat: Python Integration Tests (Module) / test_beat.py::Test::test_metricsets_0_stats failing on main after bump to 9.1

5 participants

@strawgate @elasticmachine @pkoutsovasilis @jlind23