refactor: drop custom fsync implementation #42066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upstream is using F_FULLFSYNC on darwin call stdlib f.sync and remove custom fsync implementation
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
|
mergify
bot
added
the
backport-8.x
6 tasks
kruskall
commented
Dec 16, 2024
kruskall
changed the title
Member
Author
|
@elastic/elastic-agent-data-plane friendly ping for review 🙂 |
mauri870
approved these changes
Mar 5, 2025
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
botelastic
bot
removed
the
needs_team
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
* refactor: drop custom fsync implement upstream is using F_FULLFSYNC on darwin call stdlib f.sync and remove custom fsync implementation * lint: fix linting errors * Update util.go (cherry picked from commit 40a68d4)
6 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Mar 6, 2025
…-packaging-steps * upstream/main: filebeat: make deep copy before notifying of config change (elastic#42992) [metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon' module (elastic#43002) Don't package arm64 on amd64 workers (elastic#43026) [REVERT] Update Stack Monitoring data stream to 9 (elastic#43052) FIPS Build (elastic#42402) refactor: drop custom fsync implementation (elastic#42066) Update CHANGELOG.asciidoc docs: Prepare Changelog for 8.17.3 (elastic#42980) (elastic#43029) Fix boolean key in security pipelines and sync pipelines with integration. (elastic#43027) Skip test case for sequoia (elastic#42996) [main](backport elastic#42976) docs: Prepare Changelog for 8.16.5 (elastic#43005) x-pack/filebeat/input/entityanalytics/provider/activedirectory: do not consider computers to be users (elastic#42796)
kruskall
added a commit
that referenced
this pull request
Mar 11, 2025
* refactor: drop custom fsync implement upstream is using F_FULLFSYNC on darwin call stdlib f.sync and remove custom fsync implementation * lint: fix linting errors * Update util.go (cherry picked from commit 40a68d4) Co-authored-by: kruskall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
upstream is using F_FULLFSYNC on darwin
call stdlib f.sync and remove custom fsync implementation
See https://go.dev/doc/go1.12#ospkgos
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs