Skip to content

[8.17](backport #41944) Additional stats fields for Elasticsearch#42027

Merged
consulthys merged 1 commit into8.17from
mergify/bp/8.17/pr-41944
Dec 13, 2024
Merged

[8.17](backport #41944) Additional stats fields for Elasticsearch#42027
consulthys merged 1 commit into8.17from
mergify/bp/8.17/pr-41944

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 13, 2024

This aims to replace #41652

Proposed commit message

Adds creation_date and tier_preference fields for elasticsearch.index dataset.
This will be necessary for further development through elastic/integrations#11656

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation.
  • I have made corresponding change to the default configuration files N/A
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Regarding the documentation, the example document is copied from the data.json file, accurately modified in this PR.

Another modification in the integrations repo will be required (for this file)

Disruptive User Impact

This "shouldn't" have an impact on end-users, this doesn't alter existing behavior but only adds 2 new fields that will be exposed in the gathered Elasticsearch monitoring stats.

Author's Checklist

How to test this PR locally

You can run the integration against any cluster (with xpack or otherwise) and check that the generated index stats documents have the two new fields:

  • creation_date
  • tier_preference

Screenshots

image

Performance

Below is a table presenting the impact of the addition of the extra API call, compared to fetching from cluster state (#41652) or the current code

| Case                | Response size bytes           | Delta from baseline | Response time ms       | Delta from baseline |
|---------------------|-------------------------------|---------------------|------------------------|---------------------|
| Baseline            | 14540971                      | 0%                  | 673.9                  | 0%                  |
| From cluster state  | 15679947                      | +7.8%               | 7727.0                 | +1046%              |
| Additional API call | 15018034 + 6120662 = 21138696 | +45.4%              | 673.9 + 892.2 = 1566.1 | +132%               |

Bear in mind the target monitored cluster is in us-east-1 whereas I monitored from EMEA central (Switzerland), the two round trips probably contribute to a lot of the latency. I could run an additional test from a local cloud instance, if we want to refine the measurements.


This is an automatic backport of pull request #41944 done by Mergify.

* Perform an additional _settings API call for Elasticsearch module
* Added filter_path for cluster state & index settings fetch
* Added index creation version

(cherry picked from commit 16c753c)
@mergify mergify bot added the backport label Dec 13, 2024
@mergify mergify bot requested review from a team as code owners December 13, 2024 09:03
@mergify mergify bot assigned 3kt Dec 13, 2024
@mergify mergify bot requested review from faec and rdner and removed request for a team December 13, 2024 09:03
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 13, 2024
@consulthys consulthys added the Team:Monitoring Stack Monitoring team label Dec 13, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 13, 2024
@consulthys consulthys added enhancement needs_team Indicates that the issue/PR needs a Team:* label labels Dec 13, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 13, 2024
Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring (backporting from 8.x to 8.17)

@consulthys consulthys enabled auto-merge (squash) December 13, 2024 09:07
@consulthys consulthys merged commit 6ae9009 into 8.17 Dec 13, 2024
@consulthys consulthys deleted the mergify/bp/8.17/pr-41944 branch December 13, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants