[8.17](backport #41944) Additional stats fields for Elasticsearch#42027
Merged
consulthys merged 1 commit into8.17from Dec 13, 2024
Merged
[8.17](backport #41944) Additional stats fields for Elasticsearch#42027consulthys merged 1 commit into8.17from
consulthys merged 1 commit into8.17from
Conversation
* Perform an additional _settings API call for Elasticsearch module * Added filter_path for cluster state & index settings fetch * Added index creation version (cherry picked from commit 16c753c)
consulthys
approved these changes
Dec 13, 2024
Contributor
consulthys
left a comment
There was a problem hiding this comment.
LGT Stack Monitoring (backporting from 8.x to 8.17)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to replace #41652
Proposed commit message
Adds
creation_dateandtier_preferencefields forelasticsearch.indexdataset.This will be necessary for further development through elastic/integrations#11656
Checklist
I have made corresponding change to the default configuration filesN/ACHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Regarding the documentation, the example document is copied from the
data.jsonfile, accurately modified in this PR.Another modification in the
integrationsrepo will be required (for this file)Disruptive User Impact
This "shouldn't" have an impact on end-users, this doesn't alter existing behavior but only adds 2 new fields that will be exposed in the gathered Elasticsearch monitoring stats.
Author's Checklist
How to test this PR locally
You can run the integration against any cluster (with
xpackor otherwise) and check that the generated index stats documents have the two new fields:creation_datetier_preferenceScreenshots
Performance
Below is a table presenting the impact of the addition of the extra API call, compared to fetching from cluster state (#41652) or the current code
Bear in mind the target monitored cluster is in
us-east-1whereas I monitored from EMEA central (Switzerland), the two round trips probably contribute to a lot of the latency. I could run an additional test from a local cloud instance, if we want to refine the measurements.This is an automatic backport of pull request #41944 done by Mergify.