-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(golangci): bump golangci-lint to 2.0.2 #42026
Conversation
required to support go 1.23
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR still applicable?
Looking like Linux+Windows lint tasks are failing
we can close it, it was opened for the go version bump but it's not necessary |
@elastic/observablt-robots friendly ping for review 🙂 |
|
The files are formatted correctly, this seems like an issue with golangci :( |
The Windows error about the license header:
Can be fixed by adding a
|
* ci(golangci): bump golangci-lint to 1.62.2 required to support go 1.23 * Update .golangci.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update .golangci.yml * Update .golangci.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update .golangci.yml * feat: fix dockerlogbeat compile errors on windows * Update reader.go * Update fifo_windows.go * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update fifo_nowindows.go * Update fifo_nowindows.go * Update fifo_windows.go * Update fifo_windows.go * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update reader.go * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * feat: run golangci-lint migrate * Update .gitattributes --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit a6cb1bf)
* ci(golangci): bump golangci-lint to 1.62.2 required to support go 1.23 * Update .golangci.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update .golangci.yml * Update .golangci.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update .golangci.yml * feat: fix dockerlogbeat compile errors on windows * Update reader.go * Update fifo_windows.go * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update fifo_nowindows.go * Update fifo_nowindows.go * Update fifo_windows.go * Update fifo_windows.go * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update reader.go * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * Update golangci-lint.yml * feat: run golangci-lint migrate * Update .gitattributes --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit a6cb1bf) Co-authored-by: kruskall <[email protected]>
Proposed commit message
bump golangci-lint to 1.59.1
remove deprecated go options, by default it uses go.mod version
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs