Skip to content

[8.x](backport #41730) [winlogbeat] Fix how we check for dynamic values in message templates #41745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marc-gr merged 1 commit into from
Nov 22, 2024
Merged

[8.x](backport #41730) [winlogbeat] Fix how we check for dynamic values in message templates #41745

marc-gr merged 1 commit into from
Nov 22, 2024

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 22, 2024 •
edited by zube bot
Loading

Proposed commit message

  • Fix how we check for dynamic values in message templates.
    In the experimental api we set a static message under the assumption it was not a dynamic template in cases where the whole
    message was a single data value.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

This is an automatic backport of pull request #41730 done by [Mergify](https://mergify.com).

@marc-gr @mergify
[winlogbeat] Fix how we check for dynamic values in message templates (…
341ede2 
…#41730)

* Fix how we check for dynamic values in message templates

* Fix test

* Remove dokan1 test

(cherry picked from commit 61df1f2)
@mergify mergify bot added the backport label Nov 22, 2024
@mergify mergify bot requested a review from a team as a code owner November 22, 2024 10:48
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 22, 2024
@botelastic
Copy link

botelastic bot commented Nov 22, 2024

This pull request doesn't have a Team:<team> label.

@marc-gr marc-gr enabled auto-merge (squash) November 22, 2024 10:58
@marc-gr marc-gr merged commit 3cd5905 into 8.x Nov 22, 2024
7 checks passed
@marc-gr marc-gr deleted the mergify/bp/8.x/pr-41730 branch November 22, 2024 11:16
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees

@marc-gr marc-gr

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marc-gr