Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metricbeat receiver #41738

Merged
merged 5 commits into from
Nov 25, 2024
Merged

add metricbeat receiver #41738

merged 5 commits into from
Nov 25, 2024
+272 −3

Conversation

leehinman
Copy link
Contributor

Proposed commit message

This adds a metricbeat OTel receiver. This is necessary to run beats as OTel receivers.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None. You have to import beats into your OTel project and instantiate a

Author's Checklist

  • [ ]

How to test this PR locally

cd x-pack/metricbeat/mbreceiver
go test -v .

Related issues

Use cases

Screenshots

Logs

@leehinman leehinman added enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.x Automated backport to the 8.x branch with mergify labels Nov 21, 2024
@leehinman leehinman requested a review from a team as a code owner November 21, 2024 16:59
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 21, 2024
@pierrehilbert pierrehilbert requested review from faec and removed request for khushijain21 November 21, 2024 17:41
AndersonQ
AndersonQ reviewed Nov 22, 2024
View reviewed changes
x-pack/metricbeat/mbreceiver/config_test.go Outdated Show resolved Hide resolved
x-pack/metricbeat/mbreceiver/config_test.go Outdated Show resolved Hide resolved
x-pack/metricbeat/mbreceiver/receiver_test.go Outdated Show resolved Hide resolved
x-pack/metricbeat/mbreceiver/receiver_test.go Show resolved Hide resolved
mauri870
mauri870 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leehinman leehinman mentioned this pull request Nov 25, 2024
Open
VihasMakwana
VihasMakwana approved these changes Nov 25, 2024
View reviewed changes
x-pack/metricbeat/mbreceiver/config.go Outdated Show resolved Hide resolved
@leehinman leehinman enabled auto-merge (squash) November 25, 2024 18:29
@leehinman leehinman merged commit 6203368 into elastic:main Nov 25, 2024
30 checks passed
mergify bot pushed a commit that referenced this pull request Nov 25, 2024
@leehinman @mergify
add metricbeat receiver (#41738)
74ae185 
* add metricbeat receiver

(cherry picked from commit 6203368)
@mergify mergify bot mentioned this pull request Nov 25, 2024
Merged
6 tasks
leehinman added a commit that referenced this pull request Nov 26, 2024
@mergify @leehinman
add metricbeat receiver (#41738) (#41779)
daf8f16 
* add metricbeat receiver

(cherry picked from commit 6203368)

Co-authored-by: Lee E Hinman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@mauri870 mauri870 mauri870 approved these changes

@faec faec Awaiting requested review from faec

@AndersonQ AndersonQ Awaiting requested review from AndersonQ

Assignees

@leehinman leehinman

Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[metricbeat] add metricbeat receiver
5 participants
@leehinman @elasticmachine @AndersonQ @mauri870 @VihasMakwana