Skip to content

Conversation

@kruskall
Copy link
Member

Proposed commit message

badger v4 caused compile errors for clients using badger v2 + beats due to ristretto breaking binary compatibility without bumping the major version.
badger v4.4.0 solved the issue by using ristretto v2

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

badger v4 caused compile errors for clients using badger v2 + beats
due to ristretto breaking binary compatibility without bumping the major
version.
badger v4.4.0 solved the issue by using ristretto v2
@kruskall kruskall requested a review from a team as a code owner November 18, 2024 21:05
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2024
@botelastic
Copy link

botelastic bot commented Nov 18, 2024

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 18, 2024
@kruskall kruskall added the release-note:skip The PR should be ignored when processing the changelog label Nov 18, 2024
@kruskall kruskall merged commit a522dbe into elastic:main Nov 21, 2024
6 checks passed
@kruskall kruskall deleted the feat/bump-badger-again branch November 21, 2024 17:53
mergify bot pushed a commit that referenced this pull request Nov 21, 2024
* feat: bump badger to use ristretto v2

badger v4 caused compile errors for clients using badger v2 + beats
due to ristretto breaking binary compatibility without bumping the major
version.
badger v4.4.0 solved the issue by using ristretto v2

* lint: regenerate notice file

(cherry picked from commit a522dbe)
kruskall added a commit that referenced this pull request Nov 21, 2024
* feat: bump badger to use ristretto v2

badger v4 caused compile errors for clients using badger v2 + beats
due to ristretto breaking binary compatibility without bumping the major
version.
badger v4.4.0 solved the issue by using ristretto v2

* lint: regenerate notice file

(cherry picked from commit a522dbe)

Co-authored-by: kruskall <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify enhancement needs_team Indicates that the issue/PR needs a Team:* label release-note:skip The PR should be ignored when processing the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants