feat: remove 32bit platformcheck #41544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beats and all downstream clients dropped support for 32bit artifacts remove the native platform check as it will always pass
botelastic
bot
added
the
needs_team
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
|
mergify
bot
added
the
backport-8.x
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
cmacknz
approved these changes
Nov 25, 2024
Member
cmacknz
left a comment
cmacknz
left a comment
There was a problem hiding this comment.
Agree this check is mostly pointless now, the code can't even be easily tested anymore.
mergify bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
beats and all downstream clients dropped support for 32bit artifacts remove the native platform check as it will always pass (cherry picked from commit 24d7cf0)
6 tasks
pierrehilbert
pushed a commit
that referenced
this pull request
Nov 26, 2024
beats and all downstream clients dropped support for 32bit artifacts remove the native platform check as it will always pass (cherry picked from commit 24d7cf0) Co-authored-by: kruskall <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
beats and all downstream clients dropped support for 32bit artifacts
remove the native platform check as it will always pass
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs