go.mod - use elastic/goja fork #41541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to the elastic/goja fork instead of andrewkroh/goja. This the same code just moved into the elastic org and tagged with v2019-01-28+beats. For background, this fork contains a small change to goja that allows arbitrary map types (such as elastic's "MapStr" type) to be treated as javascript objects without requiring any conversion. Also note that since the time of the fork in 2019, there is now a path to accomplish this without a fork by implementing a `toValue(r *goja.Runtime) goja.Value` method on MapStr. It would mean introducing a direct dependency on goja. A tested example of can be found in the linked gist. https://gist.github.com/andrewkroh/19eccc0844bb935222914234c9510aa1 https://github.com/elastic/goja/releases/tag/v2019-01-28%2Bbeats
botelastic
bot
added
the
needs_team
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Contributor
|
|
mergify
bot
added
the
backport-8.x
andrewkroh
added
the
Team:Elastic-Agent-Data-Plane
botelastic
bot
removed
the
needs_team
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
cmacknz
approved these changes
Nov 6, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Move to the elastic/goja fork instead of andrewkroh/goja. This the same code just moved into the elastic org and tagged with v2019-01-28+beats. For background, this fork contains a small change to goja that allows arbitrary map types (such as elastic's "MapStr" type) to be treated as javascript objects without requiring any conversion. Also note that since the time of the fork in 2019, there is now a path to accomplish this without a fork by implementing a `toValue(r *goja.Runtime) goja.Value` method on MapStr. It would mean introducing a direct dependency on goja. A tested example of can be found in the linked gist. https://gist.github.com/andrewkroh/19eccc0844bb935222914234c9510aa1 https://github.com/elastic/goja/releases/tag/v2019-01-28%2Bbeats (cherry picked from commit 8a7e9cf)
andrewkroh
added a commit
that referenced
this pull request
Nov 6, 2024
Move to the elastic/goja fork instead of andrewkroh/goja. This the same code just moved into the elastic org and tagged with v2019-01-28+beats. For background, this fork contains a small change to goja that allows arbitrary map types (such as elastic's "MapStr" type) to be treated as javascript objects without requiring any conversion. Also note that since the time of the fork in 2019, there is now a path to accomplish this without a fork by implementing a `toValue(r *goja.Runtime) goja.Value` method on MapStr. It would mean introducing a direct dependency on goja. A tested example of can be found in the linked gist. https://gist.github.com/andrewkroh/19eccc0844bb935222914234c9510aa1 https://github.com/elastic/goja/releases/tag/v2019-01-28%2Bbeats (cherry picked from commit 8a7e9cf) Co-authored-by: Andrew Kroh <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Move to the elastic/goja fork instead of andrewkroh/goja. This is the same code just moved into the elastic org and tagged with
v2019-01-28+beats.For background, this fork contains a small change to goja that allows arbitrary map types (such as elastic's "MapStr" type) to be treated as javascript objects without requiring any conversion.
Also note that since the time of the fork in 2019, there is now a path to accomplish this without a fork by implementing a
toValue(r *goja.Runtime) goja.Valuemethod on MapStr. It would mean introducing a direct dependency on goja. A tested example of can be found in the linked gist.https://gist.github.com/andrewkroh/19eccc0844bb935222914234c9510aa1
https://github.com/elastic/goja/releases/tag/v2019-01-28%2Bbeats