Skip to content

Conversation

@khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Nov 5, 2024

Proposed commit message

We were modifying config.Fields while iterating over it (in drop_fields processor) - which can lead to unexpected behavior, such as skipping elements or accessing out-of-bounds indices.

This PR now makes sure not to drop mandatory fields.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Does this require changelog entry?

@khushijain21 khushijain21 requested a review from a team as a code owner November 5, 2024 06:43
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 5, 2024
@khushijain21 khushijain21 requested a review from rdner November 5, 2024 06:44
@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 5, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 5, 2024
@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 5, 2024
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me but we should address all linter issues before merging.

@khushijain21 khushijain21 merged commit fde942b into elastic:main Nov 5, 2024
mergify bot pushed a commit that referenced this pull request Nov 5, 2024
* [libbeat] Do not modify slice while iterating over it

* fix linting

* fix regex test case failing

(cherry picked from commit fde942b)
rdner pushed a commit that referenced this pull request Nov 5, 2024
* [libbeat] Do not modify slice while iterating over it

* fix linting

* fix regex test case failing

(cherry picked from commit fde942b)

Co-authored-by: Khushi Jain <[email protected]>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify bugfix Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants