Abstracting pod interface in kubernetes plugin to enable easier vendoring #4152
Conversation
vjsamuel
force-pushed
the
abstract_pod_interface
branch
from
d3fb9f4
to
dfc223b
Compare
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
| @@ -8,6 +8,8 @@ import ( | |||
| "github.com/elastic/beats/libbeat/common" | |||
| "github.com/elastic/beats/libbeat/logp" | |||
|
|
|||
| "encoding/json" | |||
There was a problem hiding this comment.
bleh! i hate it when it does that.
| @@ -160,187 +160,6 @@ | |||
| "revisionTime": "2016-09-16T08:04:11Z" | |||
| }, | |||
| { | |||
| "checksumSHA1": "K0iEPnt2DZL5/YrrzAQoMnA+9Pc=", | |||
|
@exekias Could also please have a look? |
|
jenkins, test it |
vjsamuel
force-pushed
the
abstract_pod_interface
branch
from
dfc223b
to
352f637
Compare
| @@ -20,7 +20,7 @@ import ( | |||
| "github.com/elastic/beats/filebeat/spooler" | |||
|
|
|||
| // Add filebeat level processors | |||
| _ "github.com/elastic/beats/filebeat/processors/kubernetes" | |||
| _ "github.com/elastic/beats/filebeat/processor/kubernetes" | |||
There was a problem hiding this comment.
I think we should keep consistency with libbeat (which uses processors)
There was a problem hiding this comment.
@exekias I disagree on this one as we should change it for some time in libbeat to processor. It is processors for historical reasons.
There was a problem hiding this comment.
Ok then, it seems this was agreed some time ago 👍
|
|
||
| for _, index := range p.indexers.GetIndexes(pod) { | ||
| delete(p.annotationCache.annotations, index) | ||
| } | ||
| } | ||
|
|
||
| func (p *PodWatcher) getPodMeta(pod *corev1.Pod) *Pod { | ||
|
|
There was a problem hiding this comment.
Could you please remove the spurious empty lines at the beginning and end of this function?
vjsamuel
force-pushed
the
abstract_pod_interface
branch
from
352f637
to
bcbae50
Compare
When a user creates an Indexer outside of the beats repo, he/she needs to vendor in the k8s repo. This should ideally be unnecessary as the retrieval of Pods is abstracted from the user. This PR aims at adding a wrapper struct
Podwhich would be passed to Indexers to retrieve metadata.